Fixing tooltip for vertical toolbar in schema designer#21500
Merged
Conversation
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21500 +/- ##
=======================================
Coverage 72.54% 72.54%
=======================================
Files 330 330
Lines 98165 98165
Branches 5452 5452
=======================================
Hits 71216 71216
Misses 26949 26949
🚀 New features to boost your workflow:
|
caohai
approved these changes
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Schema Designer webview vertical toolbar tooltips so they trigger correctly over the icons, and updates the displayed labels for the Schema Designer and DAB entries (addressing the “DAB” acronym tooltip concern from #21497).
Changes:
- Wrapes vertical
ToolbarButtons in Fluent UITooltipto correct tooltip hover hitbox behavior. - Updates Schema Designer/DAB nav label strings in webview loc constants.
- Updates localization assets (
bundle.l10n.json+ base XLIFF) for the new strings.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| localization/xliff/vscode-mssql.xlf | Adds new trans-units and removes the old “DAB” trans-unit in the base XLIFF. |
| extensions/mssql/src/reactviews/pages/SchemaDesigner/index.tsx | Wraps toolbar buttons with Tooltip so tooltips show when hovering the icon itself. |
| extensions/mssql/src/reactviews/common/locConstants.ts | Changes tooltip/nav label strings for Schema Designer and DAB entries. |
| extensions/mssql/l10n/bundle.l10n.json | Adds/remaps string keys needed by the updated webview labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #21497
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines