Skip to content

Fixing tooltip for vertical toolbar in schema designer#21500

Merged
aasimkhan30 merged 2 commits into
mainfrom
aasim/fix/21497
Mar 6, 2026
Merged

Fixing tooltip for vertical toolbar in schema designer#21500
aasimkhan30 merged 2 commits into
mainfrom
aasim/fix/21497

Conversation

@aasimkhan30
Copy link
Copy Markdown
Contributor

Description

Fixes: #21497

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 6402 KB 6402 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 7025 KB 7025 KB ⚪ 0 KB ( 0% )
data-workspace VSIX 535 KB 535 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.54%. Comparing base (ce2d985) to head (482f66a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #21500   +/-   ##
=======================================
  Coverage   72.54%   72.54%           
=======================================
  Files         330      330           
  Lines       98165    98165           
  Branches     5452     5452           
=======================================
  Hits        71216    71216           
  Misses      26949    26949           
Files with missing lines Coverage Δ
...nsions/mssql/src/reactviews/common/locConstants.ts 25.14% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasimkhan30 aasimkhan30 marked this pull request as ready for review March 6, 2026 21:46
Copilot AI review requested due to automatic review settings March 6, 2026 21:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Schema Designer webview vertical toolbar tooltips so they trigger correctly over the icons, and updates the displayed labels for the Schema Designer and DAB entries (addressing the “DAB” acronym tooltip concern from #21497).

Changes:

  • Wrapes vertical ToolbarButtons in Fluent UI Tooltip to correct tooltip hover hitbox behavior.
  • Updates Schema Designer/DAB nav label strings in webview loc constants.
  • Updates localization assets (bundle.l10n.json + base XLIFF) for the new strings.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
localization/xliff/vscode-mssql.xlf Adds new trans-units and removes the old “DAB” trans-unit in the base XLIFF.
extensions/mssql/src/reactviews/pages/SchemaDesigner/index.tsx Wraps toolbar buttons with Tooltip so tooltips show when hovering the icon itself.
extensions/mssql/src/reactviews/common/locConstants.ts Changes tooltip/nav label strings for Schema Designer and DAB entries.
extensions/mssql/l10n/bundle.l10n.json Adds/remaps string keys needed by the updated webview labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread extensions/mssql/l10n/bundle.l10n.json
Comment thread localization/xliff/vscode-mssql.xlf
Comment thread localization/xliff/vscode-mssql.xlf
Comment thread extensions/mssql/src/reactviews/common/locConstants.ts
@aasimkhan30 aasimkhan30 merged commit 06b993b into main Mar 6, 2026
7 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/21497 branch March 6, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Tooltip for Schema Designer/DAB menu item has wrong hitbox

4 participants