Skip to content

Launch Query Profiler 'in active' instead that beside#21498

Merged
allancascante merged 1 commit into
mainfrom
dev/allancascante/profiler_reveal_active
Mar 6, 2026
Merged

Launch Query Profiler 'in active' instead that beside#21498
allancascante merged 1 commit into
mainfrom
dev/allancascante/profiler_reveal_active

Conversation

@allancascante
Copy link
Copy Markdown
Contributor

@allancascante allancascante commented Mar 6, 2026

Description

Change to launch view in active instead of beside.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Query Profiler webview’s default editor-column placement so it opens in the currently active column rather than always opening beside the current editor.

Changes:

  • Set the Profiler webview panel creation viewColumn to vscode.ViewColumn.Active (was Beside).
  • Change panel.reveal(...) calls to use vscode.ViewColumn.Active instead of Beside.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 794 to 796
public revealToForeground(): void {
this.panel.reveal(vscode.ViewColumn.Beside);
this.panel.reveal(vscode.ViewColumn.Active);
}
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revealToForeground() now uses ViewColumn.Active, which will move an existing profiler panel into whatever editor column is currently active (e.g., when re-opening an already-open XEL profiler from ProfilerController.openXelFile). If the intent is only to change the initial launch location, consider revealing without specifying a column (or using this.panel.viewColumn) so the panel is simply brought to the front without being relocated.

Copilot uses AI. Check for mistakes.
Comment on lines 143 to 145
title: title,
viewColumn: vscode.ViewColumn.Beside,
viewColumn: vscode.ViewColumn.Active,
iconPath: {
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change alters the panel placement behavior, but the existing unit test (ProfilerWebviewController Tests → "should create a WebviewPanel with correct options") only asserts that createWebviewPanel was called, not which viewColumn was requested. To prevent regressions, update the test to assert that the controller creates/reveals the panel with ViewColumn.Active (and/or preserves the expected column when revealing existing panels, depending on the intended UX).

Copilot uses AI. Check for mistakes.
@allancascante allancascante merged commit c508bff into main Mar 6, 2026
5 of 8 checks passed
@allancascante allancascante deleted the dev/allancascante/profiler_reveal_active branch March 6, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants