Skip to content

Removes row count label from notebook result grid#21496

Merged
lewis-sanchez merged 1 commit into
mainfrom
lewissanchez/sql-notebooks/fix-notebook-message-overlap
Mar 6, 2026
Merged

Removes row count label from notebook result grid#21496
lewis-sanchez merged 1 commit into
mainfrom
lewissanchez/sql-notebooks/fix-notebook-message-overlap

Conversation

@lewis-sanchez
Copy link
Copy Markdown
Contributor

@lewis-sanchez lewis-sanchez commented Mar 6, 2026

Description

This PR closes #21374

This PR removes a duplicate row count label from the notebooks result grid:

Before - you would see two messages the first was "(< row-count > row affected)" and directly below "< row-count > row(s)" :
image

After:
image

Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the duplicated row count text shown in the notebook results grid by eliminating the extra row count label rendered by the notebook grid component.

Changes:

  • Stops rendering the in-grid “{rowCount} row(s)” label in the notebook result grid container.
  • Updates the React effect dependencies to no longer include rowCount.
  • Removes the corresponding CSS styling for the deleted label.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
extensions/mssql/src/reactviews/pages/NotebookRenderer/notebookResultGrid.tsx Removes the extra row-count label from the notebook results grid rendering.
extensions/mssql/src/reactviews/pages/NotebookRenderer/notebookResultGrid.css Deletes styles associated with the removed row-count label.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 6402 KB 6402 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 7025 KB 7025 KB ⚪ 0 KB ( 0% )
data-workspace VSIX 535 KB 535 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.54%. Comparing base (ce2d985) to head (94825b9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #21496   +/-   ##
=======================================
  Coverage   72.54%   72.54%           
=======================================
  Files         330      330           
  Lines       98165    98165           
  Branches     5452     5452           
=======================================
  Hits        71216    71216           
  Misses      26949    26949           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lewis-sanchez lewis-sanchez merged commit 6e45d24 into main Mar 6, 2026
7 checks passed
@lewis-sanchez lewis-sanchez deleted the lewissanchez/sql-notebooks/fix-notebook-message-overlap branch March 6, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SQL Notebook messages and row count UI overlap

4 participants