Removes row count label from notebook result grid#21496
Merged
lewis-sanchez merged 1 commit intoMar 6, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the duplicated row count text shown in the notebook results grid by eliminating the extra row count label rendered by the notebook grid component.
Changes:
- Stops rendering the in-grid “{rowCount} row(s)” label in the notebook result grid container.
- Updates the React effect dependencies to no longer include
rowCount. - Removes the corresponding CSS styling for the deleted label.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| extensions/mssql/src/reactviews/pages/NotebookRenderer/notebookResultGrid.tsx | Removes the extra row-count label from the notebook results grid rendering. |
| extensions/mssql/src/reactviews/pages/NotebookRenderer/notebookResultGrid.css | Deletes styles associated with the removed row-count label. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21496 +/- ##
=======================================
Coverage 72.54% 72.54%
=======================================
Files 330 330
Lines 98165 98165
Branches 5452 5452
=======================================
Hits 71216 71216
Misses 26949 26949 🚀 New features to boost your workflow:
|
manujoseph85
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #21374
This PR removes a duplicate row count label from the notebooks result grid:
Before - you would see two messages the first was "(< row-count > row affected)" and directly below "< row-count > row(s)" :

After:

Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines