LEGO: Pull request from lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260306164157138 to main#21490
Merged
lewis-sanchez merged 1 commit intoMar 6, 2026
Conversation
csigs
requested review from
Benjin,
aasimkhan30,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez and
ssreerama
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This is an automated LEGO localization PR that updates Microsoft LCL (localization) files across 9 languages (de, es, fr, it, ja, ko, pt-BR, ru, zh-Hans, zh-Hant) for the vscode-mssql extension.
Changes:
- Adds new localized translation entries for recently introduced strings (e.g., "Rule enabled/disabled", "Filter by severity", "Search rules...", "Webview readiness" messages, "MSSQL: Click to connect", "transferActiveEditorConnections" setting description, and more).
- Removes obsolete translation entries that have been replaced—primarily rebranding from "SQL Notebook(s)" to "MSSQL Notebook/MSSQL", fixing "cancelled" → "canceled" spelling, and renaming "Definition" → "Show Definition" and "Publish Changes" removal.
- zh-Hant receives fewer changes than the other languages (only additions, no removals), which is normal for LEGO automation as translations arrive at different times per language.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| localization/LCL/zh-Hant/vscode-mssql.xlf.lcl | Adds 10 new localized zh-Hant entries (rules, severity, webview, query results, settings) |
| localization/LCL/zh-Hans/vscode-mssql.xlf.lcl | Adds 18 new entries and removes 7 obsolete entries for zh-Hans |
| localization/LCL/ru/vscode-mssql.xlf.lcl | Adds 12 new entries and removes 7 obsolete entries for Russian |
| localization/LCL/pt-BR/vscode-mssql.xlf.lcl | Adds 12 new entries and removes 7 obsolete entries for Brazilian Portuguese |
| localization/LCL/ko/vscode-mssql.xlf.lcl | Adds 12 new entries and removes 7 obsolete entries for Korean |
| localization/LCL/ja/vscode-mssql.xlf.lcl | Adds 12 new entries and removes 7 obsolete entries for Japanese |
| localization/LCL/it/vscode-mssql.xlf.lcl | Adds 18 new entries and removes 7 obsolete entries for Italian |
| localization/LCL/fr/vscode-mssql.xlf.lcl | Adds 12 new entries and removes 7 obsolete entries for French |
| localization/LCL/es/vscode-mssql.xlf.lcl | Adds 12 new entries and removes 7 obsolete entries for Spanish |
| localization/LCL/de/vscode-mssql.xlf.lcl | Adds 12 new entries and removes 7 obsolete entries for German |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21490 +/- ##
=======================================
Coverage 72.54% 72.54%
=======================================
Files 330 330
Lines 98008 98008
Branches 5438 5438
=======================================
Hits 71096 71096
Misses 26912 26912 🚀 New features to boost your workflow:
|
lewis-sanchez
approved these changes
Mar 6, 2026
lewis-sanchez
deleted the
lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260306164157138
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260306164157138 to main with localized lcls