Adding a dialog shell to unify dialog styling in webviews. #21489
Merged
Conversation
added 18 commits
March 6, 2026 05:59
…ons and add keyboard navigation support
…related components
…d improve layout responsiveness
… for improved layout and structure
… use DialogPageShell
…out with a new shellBody style
…upWebviewController
…privacy notice enhancements
…ut with new styles
PR Changes
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (59.37%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #21489 +/- ##
==========================================
- Coverage 72.89% 72.88% -0.01%
==========================================
Files 331 331
Lines 99162 99214 +52
Branches 5568 5568
==========================================
+ Hits 72285 72317 +32
- Misses 26877 26897 +20
🚀 New features to boost your workflow:
|
Benjin
reviewed
Mar 13, 2026
Benjin
reviewed
Mar 13, 2026
Benjin
reviewed
Mar 13, 2026
Benjin
reviewed
Mar 13, 2026
Benjin
previously approved these changes
Mar 13, 2026
…oduce ConnectionSubDialogDisplayType for consistency across components
added 2 commits
March 13, 2026 11:56
…ity and consistency
… update related components" This reverts commit 55cf71f.
…ll rule component
Benjin
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Objectives.
(Deployment, Flat file import)
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines