Skip to content

Adding a dialog shell to unify dialog styling in webviews. #21489

Merged
aasimkhan30 merged 35 commits into
mainfrom
aasim/feat/dialogShell
Mar 13, 2026
Merged

Adding a dialog shell to unify dialog styling in webviews. #21489
aasimkhan30 merged 35 commits into
mainfrom
aasim/feat/dialogShell

Conversation

@aasimkhan30
Copy link
Copy Markdown
Contributor

@aasimkhan30 aasimkhan30 commented Mar 6, 2026

Description

Objectives.

  1. Unify the look and feel of the dialogs.
  2. Unify the footer styling and primary and cancel button positions.
  3. Make dialog content responsive and scrollable.
  4. Use distinct webview icons to separate them in the tab view. Most webivews are currently using database icon.
  5. No functional changes.
  6. Skipped wizard like flow dialogs for now. I will create a separate wizard component for those.
    (Deployment, Flat file import)
  7. Skipped connection dialog for now (separate PR for it).
Dialog Before After
ConnectionGroup image image
Change Password image image
Add Firewall Group image
Filter Dialog image image
Create Database image image
Drop Database image image
Backup image image
Restore image image
Data Tier image image
Send Feedback image image
Publish Project image image

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Aasim Khan added 18 commits March 6, 2026 05:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 6424 KB 6439 KB ⚪ 15 KB ( 0% )
sql-database-projects VSIX 7061 KB 7061 KB ⚪ 0 KB ( 0% )
data-workspace VSIX 535 KB 535 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 59.37500% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.88%. Comparing base (8bcba4c) to head (7987a79).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nsions/mssql/src/reactviews/common/locConstants.ts 0.00% 12 Missing ⚠️
...rc/controllers/connectionGroupWebviewController.ts 0.00% 10 Missing ⚠️
...rc/controllers/restoreDatabaseWebviewController.ts 0.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (59.37%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21489      +/-   ##
==========================================
- Coverage   72.89%   72.88%   -0.01%     
==========================================
  Files         331      331              
  Lines       99162    99214      +52     
  Branches     5568     5568              
==========================================
+ Hits        72285    72317      +32     
- Misses      26877    26897      +20     
Files with missing lines Coverage Δ
...rc/controllers/addFirewallRuleWebviewController.ts 73.48% <100.00%> (+1.02%) ⬆️
...src/controllers/backupDatabaseWebviewController.ts 91.78% <100.00%> (+0.03%) ⬆️
...src/controllers/createDatabaseWebviewController.ts 82.62% <100.00%> (+0.29%) ⬆️
...l/src/controllers/dacpacDialogWebviewController.ts 93.67% <100.00%> (ø)
...l/src/controllers/dropDatabaseWebviewController.ts 85.02% <100.00%> (+0.36%) ⬆️
...c/controllers/objectManagementWebviewController.ts 90.51% <100.00%> (+0.29%) ⬆️
extensions/mssql/src/nps/userSurvey.ts 95.67% <100.00%> (+0.02%) ⬆️
...ons/mssql/src/sharedInterfaces/connectionDialog.ts 97.70% <100.00%> (+0.01%) ⬆️
...rc/controllers/restoreDatabaseWebviewController.ts 10.69% <0.00%> (-0.05%) ⬇️
...rc/controllers/connectionGroupWebviewController.ts 29.56% <0.00%> (-1.33%) ⬇️
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasimkhan30 aasimkhan30 marked this pull request as ready for review March 6, 2026 16:54
Copilot AI review requested due to automatic review settings March 6, 2026 16:55
Comment thread extensions/mssql/src/reactviews/common/locConstants.ts Outdated
Comment thread extensions/mssql/test/unit/objectExplorerFilter.test.ts Outdated
Benjin
Benjin previously approved these changes Mar 13, 2026
…oduce ConnectionSubDialogDisplayType for consistency across components
Copilot AI review requested due to automatic review settings March 13, 2026 18:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 52 out of 62 changed files in this pull request and generated 5 comments.

Comment thread extensions/mssql/src/reactviews/common/icons/dropDatabase.tsx Outdated
Comment thread extensions/mssql/test/unit/objectExplorerFilter.test.ts Outdated
Comment thread extensions/mssql/src/reactviews/common/locConstants.ts
Comment thread extensions/mssql/src/reactviews/common/locConstants.ts Outdated
Copilot AI review requested due to automatic review settings March 13, 2026 19:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 48 out of 58 changed files in this pull request and generated 4 comments.

Comment thread extensions/mssql/src/reactviews/common/locConstants.ts Outdated
Comment thread extensions/mssql/src/reactviews/common/dialogPageShell.tsx Outdated
Comment thread extensions/mssql/src/reactviews/common/icons/dropDatabase.tsx Outdated
Copilot AI review requested due to automatic review settings March 13, 2026 19:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 48 out of 58 changed files in this pull request and generated 3 comments.

Comment thread extensions/mssql/src/reactviews/common/locConstants.ts Outdated
Copilot AI review requested due to automatic review settings March 13, 2026 19:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 48 out of 58 changed files in this pull request and generated 1 comment.

Comment thread extensions/mssql/src/reactviews/common/icons/dropDatabase.tsx Outdated
@aasimkhan30 aasimkhan30 merged commit 80c1c7c into main Mar 13, 2026
3 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/feat/dialogShell branch March 13, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants