Improve schema designer tool post-open steering#21478
Merged
Merged
Conversation
caohai
requested review from
Benjin,
aasimkhan30,
allancascante,
laurenastrid1,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
aasimkhan30
previously approved these changes
Mar 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the mssql_schema_designer show success payload to better steer follow-up schema mutations through schema designer operations.
Changes:
- Expanded the
showsuccess response withrecommendedTool,recommendedNextCall, andschemaMutationPath. - Updated localized success messaging for schema designer “opened” guidance.
- Updated unit test expectations to validate the new response shape.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| localization/xliff/vscode-mssql.xlf | Adds new localized string for the updated “schema designer opened” guidance and removes the old message. |
| extensions/mssql/test/unit/schemaDesignerTool.test.ts | Updates assertions for the new success message and added response fields. |
| extensions/mssql/src/copilot/tools/schemaDesignerTool.ts | Adds new steering fields to the show success payload and switches to the new localized message key. |
| extensions/mssql/src/constants/locConstants.ts | Replaces the old success message constant with a new schema-designer-specific message. |
| extensions/mssql/l10n/bundle.l10n.json | Updates localization bundle key/value to match the new message text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR Changes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21478 +/- ##
=======================================
Coverage 72.50% 72.51%
=======================================
Files 329 329
Lines 97904 97920 +16
Branches 5429 5429
=======================================
+ Hits 70986 71002 +16
Misses 26918 26918
🚀 New features to boost your workflow:
|
aasimkhan30
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve
mssql_schema_designershowsuccess response to steer follow-up schema mutations through schema designer operations.recommendedTool,recommendedNextCall, andschemaMutationPathto the response payload.Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines