Skip to content

[Application QuickStart] [Backend] Adding Database context menu item to open DAB tab directly in Schema Designer webview#21466

Merged
manujoseph85 merged 4 commits into
mainfrom
dev/majoseph/dab-context-menu
Mar 5, 2026
Merged

[Application QuickStart] [Backend] Adding Database context menu item to open DAB tab directly in Schema Designer webview#21466
manujoseph85 merged 4 commits into
mainfrom
dev/majoseph/dab-context-menu

Conversation

@manujoseph85
Copy link
Copy Markdown
Contributor

@manujoseph85 manujoseph85 commented Mar 5, 2026

Description

This pull request introduces a new "Build Data API..." command to the MSSQL extension, enhances the schema designer command description, and updates command grouping for improved clarity and usability.

New Data API Command Integration

  • Added a new command mssql.buildDataApi to package.json, including its activation condition in Object Explorer and registration in the command palette. This command is only available when the enableDAB config is set
  • Implemented the command handler in mainController.ts to show the Data API tab in the schema designer webview (by setting activeView in the state)
  • Added the method showSchemaDesignerView to SchemaDesignerWebviewController to support toggling between schema designer and Data API views.

Command Grouping and UI

  • Updated the grouping of server and database actions in package.json to accommodate the new Data API command and ensure correct ordering of commands in the UI.
image

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Comment thread extensions/mssql/src/controllers/mainController.ts Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 6400 KB 6386 KB ⚪ -14 KB ( 0% )
sql-database-projects VSIX 7024 KB 7024 KB ⚪ 0 KB ( 0% )
data-workspace VSIX 535 KB 535 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 46.66667% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.82%. Comparing base (8deebc1) to head (d31b56c).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
extensions/mssql/src/controllers/mainController.ts 39.13% 14 Missing ⚠️
extensions/mssql/src/copilot/chatCommands.ts 50.00% 1 Missing ⚠️
.../schemaDesigner/schemaDesignerWebviewController.ts 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (46.66%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21466      +/-   ##
==========================================
- Coverage   72.83%   72.82%   -0.01%     
==========================================
  Files         325      325              
  Lines       96419    96446      +27     
  Branches     5411     5411              
==========================================
+ Hits        70227    70239      +12     
- Misses      26192    26207      +15     
Files with missing lines Coverage Δ
extensions/mssql/src/constants/constants.ts 100.00% <100.00%> (ø)
extensions/mssql/src/copilot/tools/dabTool.ts 98.92% <100.00%> (+<0.01%) ⬆️
extensions/mssql/src/copilot/chatCommands.ts 89.26% <50.00%> (-0.17%) ⬇️
.../schemaDesigner/schemaDesignerWebviewController.ts 84.48% <50.00%> (ø)
extensions/mssql/src/controllers/mainController.ts 30.38% <39.13%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@manujoseph85 manujoseph85 merged commit 4a711b6 into main Mar 5, 2026
3 checks passed
@manujoseph85 manujoseph85 deleted the dev/majoseph/dab-context-menu branch March 5, 2026 21:08
"mssql.userFeedback": "Send Feedback",
"mssql.selectedAzureSubscriptions": "Selected Azure subscriptions for browsing and managing servers and databases",
"mssql.schemaDesigner": "Schema Designer",
"mssql.schemaDesigner": "Visualize and Design Schema...",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to add ... at the end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Build Data API as new context menu entry point

5 participants