Skip to content

Upgrade STS version to fix table designer delete issue#21461

Closed
aasimkhan30 wants to merge 2 commits into
mainfrom
aasim/fix/tdDelete
Closed

Upgrade STS version to fix table designer delete issue#21461
aasimkhan30 wants to merge 2 commits into
mainfrom
aasim/fix/tdDelete

Conversation

@aasimkhan30
Copy link
Copy Markdown
Contributor

Description

Upgrade the SQL Tools Service (STS) version to resolve an issue with the table designer delete functionality.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the embedded SQL Tools Service (STS) version used by the mssql extension to address a table designer delete issue by pulling a newer STS release.

Changes:

  • Bump STS version from 5.0.20260302.1 to 5.0.20260304.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 5, 2026

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 6399 KB 6385 KB ⚪ -14 KB ( 0% )
sql-database-projects VSIX 7024 KB 7024 KB ⚪ 0 KB ( 0% )
data-workspace VSIX 535 KB 535 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.73%. Comparing base (48e6bd8) to head (0329427).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #21461   +/-   ##
=======================================
  Coverage   72.73%   72.73%           
=======================================
  Files         325      325           
  Lines       96382    96382           
  Branches     5390     5390           
=======================================
  Hits        70100    70100           
  Misses      26282    26282           
Files with missing lines Coverage Δ
extensions/mssql/src/configurations/config.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kburtram
kburtram previously approved these changes Mar 5, 2026
Copy link
Copy Markdown
Member

@kburtram kburtram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI build failure is related to a schema designer test. It's worth confirming that it's not related.

@aasimkhan30
Copy link
Copy Markdown
Contributor Author

Seems to be transient

@aasimkhan30 aasimkhan30 closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants