F5 will execute notebook SQL cells#21457
Merged
lewis-sanchez merged 2 commits intoMar 5, 2026
Merged
Conversation
lewis-sanchez
requested review from
Benjin,
aasimkhan30,
allancascante,
caohai,
kburtram,
laurenastrid1,
manujoseph85 and
ssreerama
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the database-management keymap so F5 runs SQL queries in editors but executes a notebook cell when working inside a notebook, aligning notebook UX more closely with the SQL editor experience.
Changes:
- Updates the existing F5 →
mssql.runQuerybinding to exclude notebook contexts (!notebookEditorFocused). - Adds a new F5 →
notebook.cell.executebinding when notebook cells are focused.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21457 +/- ##
=======================================
Coverage 72.91% 72.91%
=======================================
Files 325 325
Lines 96667 96667
Branches 5415 5415
=======================================
Hits 70483 70483
Misses 26184 26184 🚀 New features to boost your workflow:
|
aasimkhan30
approved these changes
Mar 5, 2026
lewis-sanchez
deleted the
lewissanchez/sql-notebooks/fix-query-execute-shortcut
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #21337
The PR allows F5 to execute SQL notebook cells
Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines