Code review changes for SQL Notebooks by lewis-sanchez · Pull Request #21439 · microsoft/vscode-mssql

lewis-sanchez · 2026-03-04T02:36:15Z

Description

This PR addresses the code review feedback from this pull request: #21324

Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.

Code Changes Checklist

New or updated unit tests added
All existing tests pass (npm run test)
Code follows contributing guidelines
Telemetry/logging updated if relevant
No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

The `NotebookConnectionManager.connectWith` method no longer performs a database mismatch check followed by a disconnect and reconnect. Previously, if the actual database reported by the connection service (STS) differed from the database specified in the initial `IConnectionInfo`, the manager would attempt to reconnect to the correct database. This logic is now removed. The manager now directly accepts the database reported by STS as the active database for the connection, simplifying the connection flow and avoiding unnecessary reconnect cycles. This prioritizes the actual connected database for internal state management.

Copilot

Pull request overview

Follow-up changes to the SQL Notebooks feature to incorporate review feedback from #21324, including moving notebook execution onto STS query notifications, reusing shared result-grid behaviors in the notebook renderer, and aligning notebook UI strings with “MSSQL” branding/localization.

Changes:

Replaced notebook batch parsing + simple-query execution with an STS notification–driven NotebookQueryExecutor (query/executeString + subset fetching + cancel/dispose).
Reused the shared Query Result grid CellSelectionModel and shared table icon CSS in the notebook renderer; removed notebook-specific selection model.
Updated notebook-related localization strings (“MSSQL …”, “canceled”) and adjusted relevant unit tests.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
localization/xliff/vscode-mssql.xlf	Adds/updates notebook + cancellation trans-units and renames notebook strings to “MSSQL …”.
extensions/mssql/l10n/bundle.l10n.json	Updates runtime l10n bundle keys for the renamed notebook strings and cancellation spelling.
extensions/mssql/src/constants/locConstants.ts	Renames notebook status bar strings to “MSSQL …” and updates cancellation string to “canceled”.
extensions/mssql/src/notebooks/sqlNotebookController.ts	Switches execution path to `executeQueryString` (single call) + batch-output formatting; supports DI factory for tests; updates naming to MSSQL.
extensions/mssql/src/notebooks/notebookQueryExecutor.ts	New executor that wraps STS query notifications into a promise-based API, including subset row fetching and best-effort cancel/dispose.
extensions/mssql/src/notebooks/notebookConnectionManager.ts	Uses STS-populated connection info for “actual database”, delegates execution to `NotebookQueryExecutor`, removes old simple-query DB verification/cancel path.
extensions/mssql/src/models/contracts/queryExecute.ts	Adds `QueryExecuteStringRequest` + params for STS `query/executeString`.
extensions/mssql/src/controllers/queryNotificationHandler.ts	Generalizes runner tracking to `IQueryEventHandler` (decouples from `QueryRunner`).
extensions/mssql/src/reactviews/pages/QueryResult/table/plugins/cellSelectionModel.plugin.ts	Makes context/keybinding deps optional and adds a “basic keyboard support” fallback for notebook renderer usage.
extensions/mssql/src/reactviews/pages/NotebookRenderer/notebookResultGrid.tsx	Switches to shared `CellSelectionModel` and imports shared `table.css`.
extensions/mssql/src/reactviews/pages/NotebookRenderer/notebookResultGrid.css	Removes notebook-local button styling; adds notebook-specific overrides for shared sort/filter button classes.
extensions/mssql/src/reactviews/pages/NotebookRenderer/notebookHeaderMenu.plugin.ts	Uses shared CSS-driven icons/classes instead of inline SVGs; toggles state via CSS classes.
extensions/mssql/src/reactviews/pages/NotebookRenderer/notebookContextMenu.plugin.ts	Expands rationale comment describing why notebook context menu is separate from QueryResult context menu.
extensions/mssql/scripts/bundle-notebook-renderer.js	Enhances CSS inlining to rewrite `url()` assets to inline data URIs for iframe renderer.
extensions/mssql/src/notebooks/notebookCodeLensProvider.ts	Clarifies why “last active connection” logic doesn’t work for notebooks.
extensions/mssql/test/unit/sqlNotebookController.test.ts	Updates controller tests to use a mocked `NotebookConnectionManager` + new result shape.
extensions/mssql/test/unit/notebookQueryExecutor.test.ts	Adds unit tests for the new STS-notification based executor.
extensions/mssql/test/unit/notebookConnectionManager.test.ts	Updates tests for new execution path and connection-info behavior.
extensions/mssql/test/unit/batchParser.test.ts	Removes tests for deleted batch parser.
extensions/mssql/src/notebooks/batchParser.ts	Removes batch parsing helper in favor of STS batch handling.
extensions/mssql/src/reactviews/pages/NotebookRenderer/notebookCellSelectionModel.plugin.ts	Removes notebook-specific cell selection model in favor of shared implementation.

Comments suppressed due to low confidence (1)

extensions/mssql/src/notebooks/notebookConnectionManager.ts:133

promptAndConnect formats the connection label using actualDb, but then stores the original connectionInfo (which may still contain the requested/previous database). This can desync getCurrentDatabase() / future changeDatabase() calls from what STS actually opened. Store this.connectionInfo with the resolved actualDb (fallback to the profile DB if actualDb is "(unknown)").

            const actualDb = this.getActualDatabase(uri);
            this.log.info(`[promptAndConnect] Actual DB: ${actualDb}`);
            this.connectionLabel = formatConnectionLabel(connectionInfo.server, actualDb);

            this.connectionUri = uri;
            this.connectionInfo = connectionInfo;
            activity.end(ActivityStatus.Succeeded);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-04T02:43:31Z

+        // Get the actual database name from the connection info that STS populated
+        const actualDb = this.getActualDatabase(uri);
        this.log.info(`[changeDatabase] Verified: ${actualDb}`);

        this.connectionUri = uri;
        this.connectionInfo = newInfo;
        this.connectionLabel = formatConnectionLabel(newInfo.server, actualDb);
    }


changeDatabase verifies the actual DB via getActualDatabase(uri) and uses it for connectionLabel, but it keeps this.connectionInfo = newInfo (the requested DB). This means getCurrentDatabase() can return a different DB than what the label/STS session is actually using. Update this.connectionInfo to reflect actualDb (with a sensible fallback when actualDb is "(unknown)").

Copilot · 2026-03-04T02:43:31Z

+    <trans-unit id="++CODE++65298a316736d0742788a35a1a44d804842b5f5d39234b03faa3be7815a545e4">
+      <source xml:lang="en">MSSQL Notebook connected to {0}</source>
+      <note>{0} is the connection label</note>
+    </trans-unit>
+    <trans-unit id="++CODE++99a3297c47d9336c0c32fe572074cba7cd53bf9b0d5988c14d3335dd468e2c37">
+      <source xml:lang="en">MSSQL: Not connected</source>
+    </trans-unit>
    <trans-unit id="++CODE++845cd20358ee1964f66ca8b28c6df89c00d0f59d43a3e8e3f3d65a515194a1da">
      <source xml:lang="en">MSSQL: Welcome &amp; What&apos;s New</source>
    </trans-unit>
+    <trans-unit id="++CODE++2b136410190298a2840e44bf76dd88579edad1f2b56366e66685938b77821aa4">
+      <source xml:lang="en">MSSQL: click to change database</source>
+    </trans-unit>
+    <trans-unit id="++CODE++b42a988a00b3328f2d2a752321195c33513a2daafb555eac4dc97540e9978b5f">
+      <source xml:lang="en">MSSQL: click to connect</source>
+    </trans-unit>


New/updated trans-units were added here (notebook status bar + cancellation strings). In this repo, when adding/changing strings in vscode-mssql.xlf, the same trans-unit IDs should be mirrored into each localized vscode-mssql.<lang>.xlf to keep localization in sync; currently only the source XLF is updated.

Copilot · 2026-03-04T02:43:31Z

+    <trans-unit id="++CODE++2da839233749a1d48af0f1399da21768ade458db40ba95dcd405a7addefad753">
+      <source xml:lang="en">Query execution was canceled.</source>
    </trans-unit>


This updated trans-unit ("Query execution was canceled.") also needs to be mirrored into each localized vscode-mssql.<lang>.xlf so non-English builds don’t fall behind when the source string changes.

github-actions · 2026-03-04T02:46:09Z

PR Changes

Category	Target Branch	PR Branch	Difference
vscode-mssql VSIX	6390 KB	6390 KB	⚪ 0 KB ( 0% )
sql-database-projects VSIX	7024 KB	7024 KB	⚪ 0 KB ( 0% )
data-workspace VSIX	535 KB	535 KB	⚪ 0 KB ( 0% )

codecov-commenter · 2026-03-04T02:55:49Z

Codecov Report

❌ Patch coverage is 92.80742% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.79%. Comparing base (5bd4782) to head (ab29b03).
⚠️ Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
...sions/mssql/src/notebooks/sqlNotebookController.ts	78.57%	24 Missing ⚠️
...sions/mssql/src/notebooks/notebookQueryExecutor.ts	97.02%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #21439      +/-   ##
==========================================
+ Coverage   72.72%   72.79%   +0.06%     
==========================================
  Files         323      323              
  Lines       96228    96441     +213     
  Branches     5360     5364       +4     
==========================================
+ Hits        69985    70206     +221     
+ Misses      26243    26235       -8

Files with missing lines	Coverage Δ
extensions/mssql/src/constants/locConstants.ts	`75.97% <100.00%> (-0.20%)`	⬇️
.../mssql/src/controllers/queryNotificationHandler.ts	`100.00% <100.00%> (ø)`
...ensions/mssql/src/models/contracts/queryExecute.ts	`90.78% <100.00%> (+0.54%)`	⬆️
...ns/mssql/src/notebooks/notebookCodeLensProvider.ts	`100.00% <100.00%> (ø)`
...s/mssql/src/notebooks/notebookConnectionManager.ts	`99.01% <100.00%> (+1.27%)`	⬆️
...sions/mssql/src/notebooks/notebookQueryExecutor.ts	`97.02% <97.02%> (ø)`
...sions/mssql/src/notebooks/sqlNotebookController.ts	`74.13% <78.57%> (+2.37%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Benjin · 2026-03-04T04:43:47Z

@lewis-sanchez can you give this a more descriptive PR title since that's what becomes the commit message?

aasimkhan30 · 2026-03-04T19:13:08Z

-// so extracted CSS files would never be loaded.
+// so extracted CSS files would never be loaded. Asset url() references (e.g. SVG
+// icons) are resolved to data URIs so they work inside the iframe.
 const inlineCssPlugin = {


Probably we should look into merging all the bundling files as there is a lot of repeated code.

aasimkhan30 · 2026-03-04T19:16:41Z

-        "SQL Notebooks: click to change database",
-    );
-    public static statusBarClickToConnect = l10n.t("SQL Notebooks: click to connect");
+    public static statusBarNotConnected = l10n.t("MSSQL: Not connected");


NIT: Maybe we shold keep the labels consistent with codelens.

Good point. We should point to the same strings.

aasimkhan30 · 2026-03-04T19:21:33Z

@@ -116,17 +124,9 @@ export class NotebookConnectionManager implements vscode.Disposable {
            const uri = await this.connectInternal(connectionInfo);


Follow up task: Please dedup this with prompt and connect from query editor. We should dup this implementation.

aasimkhan30 · 2026-03-04T19:27:36Z

+            const params = new QueryExecuteStringParams();
+            params.ownerUri = ownerUri;
+            params.query = query;
+            await this.client.sendRequest(QueryExecuteStringRequest.type, params);


How is this different than existing queryexecuteStatement?

Lewis replied elsewhere, but it has to do with lack of multi-batch support

aasimkhan30 · 2026-03-04T19:33:53Z

        } catch (err: any) {
-            if (cancelled) {
+            execution.replaceOutput([
+                new vscode.NotebookCellOutput([


Please create a helper that send this to avoid dup code.

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-04T23:07:42Z

+            this.log.info(`[promptAndConnect] Actual DB: ${actualDb}`);
+            this.connectionLabel = formatConnectionLabel(connectionInfo.server, actualDb);

            this.connectionUri = uri;
            this.connectionInfo = connectionInfo;


actualDb can be undefined (if getConnectionInfoFromUri hasn’t populated yet), but it’s passed directly into formatConnectionLabel(...). This can both (1) cause a TS type error under strictNullChecks and (2) show an incorrect label (falls back to “master”) even if the user selected a different database. Please fall back to connectionInfo.database when actualDb is undefined, and consider storing the actual DB back into this.connectionInfo for consistency.

Suggested change

this.log.info(`[promptAndConnect] Actual DB: ${actualDb}`);

this.connectionLabel = formatConnectionLabel(connectionInfo.server, actualDb);

this.connectionUri = uri;

this.connectionInfo = connectionInfo;

const effectiveDb = actualDb ?? connectionInfo.database;

this.log.info(`[promptAndConnect] Actual DB: ${actualDb}, Effective DB: ${effectiveDb}`);

this.connectionLabel = formatConnectionLabel(connectionInfo.server, effectiveDb);

this.connectionUri = uri;

this.connectionInfo = {

...connectionInfo,

database: effectiveDb,

};

Copilot · 2026-03-04T23:07:42Z

@@ -120,10 +111,9 @@ export class NotebookHeaderMenu<T extends Slick.SlickData> {
        args.node.appendChild(sortBtn);
        this._columnSortButtonMapping.set(column.id!, sortBtn);

-        // Filter button
+        // Filter button — uses shared slick-header-filterbutton class (icons via table.css)
        const filterBtn = document.createElement("button");
-        filterBtn.className = "nb-filter-button";
-        filterBtn.innerHTML = FILTER_ICON;
+        filterBtn.className = "slick-header-filterbutton";
        filterBtn.title = "Filter";
        filterBtn.tabIndex = -1;


The sort/filter header buttons are icon-only and currently only set title. For accessibility (screen readers) they should also set an aria-label (QueryResult’s header filter buttons do this). Please add aria-label attributes (ideally localized) for both the sort and filter buttons.

Copilot · 2026-03-04T23:07:43Z

+      <note>{0} is the connection label</note>
+    </trans-unit>
+    <trans-unit id="++CODE++a2b41c1abaf1dcf9e0e3f2dfadc4649810e9b986a3c53eaed96f510ec49d0ccd">
+      <source xml:lang="en">MSSQL: Click to change database</source>
+    </trans-unit>
+    <trans-unit id="++CODE++f993c79609a3d00c82d5214040869fd0b15ab7404074bc3fcf8111fcc88c5d45">
+      <source xml:lang="en">MSSQL: Click to connect</source>
+    </trans-unit>
+    <trans-unit id="++CODE++99a3297c47d9336c0c32fe572074cba7cd53bf9b0d5988c14d3335dd468e2c37">
+      <source xml:lang="en">MSSQL: Not connected</source>
+    </trans-unit>
    <trans-unit id="++CODE++845cd20358ee1964f66ca8b28c6df89c00d0f59d43a3e8e3f3d65a515194a1da">
      <source xml:lang="en">MSSQL: Welcome &amp; What&apos;s New</source>


The new/updated notebook trans-units added here (e.g. “MSSQL Notebook connected…”, “MSSQL: Click to …”, “MSSQL: Not connected”) don’t appear to be mirrored into the localized localization/xliff/vscode-mssql.<lang>.xlf files. For example, vscode-mssql.de.xlf still contains the old sources like “SQL Notebook connected to {0}”. Please add equivalent trans-units (typically with <target state="new">…</target>) to each localized file to keep localization in sync.

Suggested change

<note>{0} is the connection label</note>

</trans-unit>

<trans-unit id="++CODE++a2b41c1abaf1dcf9e0e3f2dfadc4649810e9b986a3c53eaed96f510ec49d0ccd">

<source xml:lang="en">MSSQL: Click to change database</source>

</trans-unit>

<trans-unit id="++CODE++f993c79609a3d00c82d5214040869fd0b15ab7404074bc3fcf8111fcc88c5d45">

<source xml:lang="en">MSSQL: Click to connect</source>

</trans-unit>

<trans-unit id="++CODE++99a3297c47d9336c0c32fe572074cba7cd53bf9b0d5988c14d3335dd468e2c37">

<source xml:lang="en">MSSQL: Not connected</source>

</trans-unit>

<trans-unit id="++CODE++845cd20358ee1964f66ca8b28c6df89c00d0f59d43a3e8e3f3d65a515194a1da">

<source xml:lang="en">MSSQL: Welcome & What's New</source>

<note>{0} is the connection label</note>

<target state="new">MSSQL Notebook connected to {0}</target>

</trans-unit>

<trans-unit id="++CODE++a2b41c1abaf1dcf9e0e3f2dfadc4649810e9b986a3c53eaed96f510ec49d0ccd">

<source xml:lang="en">MSSQL: Click to change database</source>

<target state="new">MSSQL: Click to change database</target>

</trans-unit>

<trans-unit id="++CODE++f993c79609a3d00c82d5214040869fd0b15ab7404074bc3fcf8111fcc88c5d45">

<source xml:lang="en">MSSQL: Click to connect</source>

<target state="new">MSSQL: Click to connect</target>

</trans-unit>

<trans-unit id="++CODE++99a3297c47d9336c0c32fe572074cba7cd53bf9b0d5988c14d3335dd468e2c37">

<source xml:lang="en">MSSQL: Not connected</source>

<target state="new">MSSQL: Not connected</target>

</trans-unit>

<trans-unit id="++CODE++845cd20358ee1964f66ca8b28c6df89c00d0f59d43a3e8e3f3d65a515194a1da">

<source xml:lang="en">MSSQL: Welcome & What's New</source>

<target state="new">MSSQL: Welcome & What's New</target>

Copilot · 2026-03-04T23:07:43Z

+    <trans-unit id="++CODE++2da839233749a1d48af0f1399da21768ade458db40ba95dcd405a7addefad753">
+      <source xml:lang="en">Query execution was canceled.</source>
    </trans-unit>


This PR changes the cancellation string to “Query execution was canceled.”, but the localized vscode-mssql.<lang>.xlf files still appear to contain the previous source “Query execution was cancelled.” (e.g. vscode-mssql.de.xlf). Please mirror this updated trans-unit into each localized XLIFF so translations stay aligned with the base file.

Benjin · 2026-03-05T05:11:13Z

+        database: "TestDB",
+        user: "sa",
+        password: "password",
+        email: undefined,


for all these undefined props, you can just delete them and cast through unknown to clean this up. Also, better to have these sorts of helpers at the bottom of the file.

Benjin · 2026-03-05T05:23:05Z

+import { IDbColumn } from "../../../src/models/interfaces";
+
+/** Creates a minimal but fully-typed IDbColumn for test data. */
+function makeColumn(columnName: string, dataTypeName: string): IDbColumn {


helper functions below test suites

Benjin · 2026-03-05T05:24:22Z

+        sb.stub(vscode.window, "createStatusBarItem").returns(
+            mockStatusBarItem as unknown as vscode.StatusBarItem,
+        );
        sb.stub(vscode.window, "createOutputChannel").returns({


For the tests, you can/should just use stubVscodeWrapper().outputChannel here and the other places that you've created custom stubs for output channel

lewis-sanchez added 16 commits March 3, 2026 11:21

Change SQL to MSSQL

f5a4337

Change cancelled to canceled

1f95bc7

Explain the need for separate build script

f7495ad

Change cancelled to canceled

f33f24f

Refactors notebook SQL query execution

3470b5e

Explain why "last connection" works for editors, but not notebooks

50b2803

Remove reference to ADS and SSMS in comment

0a07c46

Refactor notebook database name resolution

aeae4ea

Refine unknown database status handling

1b03b03

Get database name from connection info

5eb496b

Update display name from "SQL" to "MSSQL"

d3e43ac

Reason for not using existing status bar item

fe270e4

Consolidate cell selection model notebook plugin

c78b5d9

Explain the need for a separate context menu plugin

57a6440

Consolidate notebook header icons with shared CSS

931bbf6

Copilot AI review requested due to automatic review settings March 4, 2026 02:36

lewis-sanchez requested review from Benjin, aasimkhan30, allancascante, caohai, kburtram, laurenastrid1, manujoseph85 and ssreerama as code owners March 4, 2026 02:36

Copilot started reviewing on behalf of lewis-sanchez March 4, 2026 02:37 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Fix cell selection outline for notebooks

f15c5bc

lewis-sanchez changed the title ~~Code review follow up to #21324~~ Code review changes for SQL Notebooks Mar 4, 2026

Benjin reviewed Mar 4, 2026

View reviewed changes

lewis-sanchez added 10 commits March 4, 2026 10:07

Consistent capitalization

b3a0fee

Generated loc changes

46b9cb0

Explain simple query request change

30b3378

Explain separate code lens provider impl

a7fad96

Remove unknown database logic

52921a9

Remove duplicate deferred promise type

4361e3b

Make context regular code comment

85fabf2

Follow output channel naming convention

537e00e

Removes redundant telemetry for cell cancellation

1628e83

Use platform-specific EOL

3f54f20

aasimkhan30 reviewed Mar 4, 2026

View reviewed changes

Declare const for text/plain

cda5284

aasimkhan30 reviewed Mar 4, 2026

View reviewed changes

lewis-sanchez added 3 commits March 4, 2026 13:15

Fixes connection manager tests.

93c5a5d

Stub mocks with sinon

b7f9893

Move tests to notebook directory

ab29b03

Copilot AI review requested due to automatic review settings March 4, 2026 23:02

Copilot started reviewing on behalf of lewis-sanchez March 4, 2026 23:03 View session

lewis-sanchez requested a review from Benjin March 4, 2026 23:06

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Benjin reviewed Mar 5, 2026

View reviewed changes

Benjin approved these changes Mar 5, 2026

View reviewed changes

lewis-sanchez merged commit e0d5b70 into main Mar 5, 2026
7 checks passed

lewis-sanchez deleted the lewissanchez/sql-notebooks/code-review branch March 5, 2026 05:33

		@@ -116,17 +124,9 @@ export class NotebookConnectionManager implements vscode.Disposable {
		const uri = await this.connectInternal(connectionInfo);

-            this.log.info(`[promptAndConnect] Actual DB: ${actualDb}`);
-            this.connectionLabel = formatConnectionLabel(connectionInfo.server, actualDb);
-            this.connectionUri = uri;
-            this.connectionInfo = connectionInfo;
+            const effectiveDb = actualDb ?? connectionInfo.database;
+            this.log.info(`[promptAndConnect] Actual DB: ${actualDb}, Effective DB: ${effectiveDb}`);
+            this.connectionLabel = formatConnectionLabel(connectionInfo.server, effectiveDb);
+            this.connectionUri = uri;
+            this.connectionInfo = {
+                ...connectionInfo,
+                database: effectiveDb,
+            };

Conversation

lewis-sanchez commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Code Changes Checklist

Reviewers: Please read our reviewer guidelines

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Changes

Uh oh!

codecov-commenter commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Benjin commented Mar 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

lewis-sanchez commented Mar 4, 2026 •

edited

Loading

github-actions Bot commented Mar 4, 2026 •

edited

Loading

codecov-commenter commented Mar 4, 2026 •

edited

Loading