Refactoring the HTTP helper utility to improve clarity, extensibility, and robustness by ssreerama · Pull Request #21375 · microsoft/vscode-mssql

ssreerama · 2026-02-26T23:08:57Z

Description

This pull request improves the robustness of the SQL Database Projects extension's build helper, especially for environments behind a proxy or offline.

Added full support for HTTP(S) proxy detection and tunneling in HttpClient
Updated dependencies to include the tunnel package and its types for proxy support
Added a localized message guiding users on how to manually place required DLLs if nuget.org is unreachable and dlls are not present.
Refactored the check for required build DLLs
- The presence of DLLs themselves is now the source of truth.
- Not the presence of a .nupkg file
Added new tests to verify correct error messaging when downloads fail and to confirm that downloads are skipped
Removed the obsolete VSCODE_DEVELOPMENT.md documentation file

Code Changes Checklist

New or updated unit tests added
All existing tests pass (npm run test)
Code follows contributing guidelines
Telemetry/logging updated if relevant
No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

github-actions · 2026-02-26T23:43:25Z

PR Changes

Category	Target Branch	PR Branch	Difference
vscode-mssql VSIX	6402 KB	6400 KB	⚪ -2 KB ( 0% )
sql-database-projects VSIX	7025 KB	7057 KB	⚪ 32 KB ( 0% )
data-workspace VSIX	535 KB	535 KB	⚪ 0 KB ( 0% )

codecov-commenter · 2026-02-27T02:07:57Z

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.51%. Comparing base (0370a76) to head (07c2901).
⚠️ Report is 31 commits behind head on main.

Files with missing lines	Patch %	Lines
extensions/mssql/src/http/httpClientCore.ts	80.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #21375      +/-   ##
==========================================
- Coverage   72.53%   72.51%   -0.02%     
==========================================
  Files         330      330              
  Lines       97979    97987       +8     
  Branches     5431     5409      -22     
==========================================
- Hits        71066    71056      -10     
- Misses      26913    26931      +18

Files with missing lines	Coverage Δ
extensions/mssql/src/constants/locConstants.ts	`76.21% <100.00%> (ø)`
extensions/mssql/src/http/httpClientCore.ts	`84.86% <80.00%> (-3.50%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR improves the SQL Database Projects extension’s build-time dependency download path, focusing on better behavior behind proxies/offline, and refactors the “are required build DLLs present?” check to use the DLLs as the source of truth.

Changes:

Add proxy-aware tunneling support for HttpClient.download (VS Code http.proxy + env var detection).
Refactor build DLL presence checks to rely on expected DLLs rather than .nupkg presence; add a new localized “manual DLL placement” help message when downloads fail.
Add new unit tests for proxy agent selection and for build helper failure/skip-download behavior; remove obsolete VSCODE_DEVELOPMENT.md.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
localization/xliff/sql-database-projects.xlf	Adds new localized string for nuget reachability/help guidance.
extensions/sql-database-projects/package.json	Adds `tunnel` + `@types/tunnel` dependencies for proxy tunneling.
extensions/sql-database-projects/yarn.lock	Locks new tunnel dependencies.
extensions/sql-database-projects/src/common/httpClient.ts	Adds proxy detection and tunnel agent setup for downloads.
extensions/sql-database-projects/src/tools/buildHelper.ts	Changes presence check to DLL-based; shows new help message on download failures.
extensions/sql-database-projects/src/common/constants.ts	Adds `nugetDownloadFailedHelp` localized helper.
extensions/sql-database-projects/l10n/bundle.l10n.json	Adds the new l10n key/value for the help message.
extensions/sql-database-projects/test/httpClient.test.ts	New tests validating tunnel variant selection and proxy priority.
extensions/sql-database-projects/test/buildHelper.test.ts	Adds tests for error messaging on download failure and skipping download when files exist.
extensions/sql-database-projects/VSCODE_DEVELOPMENT.md	Removes obsolete developer documentation file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 16 out of 19 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-06T20:55:57Z

+        try {
+            const scheme = this.dependencies.parseUriScheme
+                ? this.dependencies.parseUriScheme(proxy)
+                : new URL(proxy).protocol;
+
+            if (!scheme) {
+                message = `Proxy settings found, but without a protocol (e.g. http://): '${proxy}'.  You may encounter connection issues while using this extension.`;
+                localizedMessage = this.dependencies.messages?.missingProtocolWarning(proxy);
+            }
+        } catch (err) {
+            const errorMessage = this.getErrorMessage(err);
+            message = `Proxy settings found, but encountered an error while parsing the URL: '${proxy}'.  You may encounter connection issues while using this extension.  Error: ${errorMessage}`;
+            localizedMessage = this.dependencies.messages?.unparseableWarning(proxy, errorMessage);
+        }
+


warnOnInvalidProxySettings currently treats any non-empty scheme as valid (e.g. socks5://...), but createProxyAgent/getProxyAgentOptions only support http/https proxies. This can lead to no warning being shown for unsupported proxy schemes, followed by request failures later. Consider warning (and/or ignoring) proxies whose scheme is not http/https.

ssreerama changed the title ~~Sai/mar/sqlproj offline dwnld issue~~ refactoring the HTTP helper utility to improve clarity, extensibility, and robustness Feb 26, 2026

ssreerama changed the title ~~refactoring the HTTP helper utility to improve clarity, extensibility, and robustness~~ Refactoring the HTTP helper utility to improve clarity, extensibility, and robustness Feb 26, 2026

ssreerama added 2 commits February 27, 2026 14:00

inital change of http client changes

03d9372

loc

bc1790c

ssreerama force-pushed the sai/mar/sqlproj_offlineDwnld_Issue branch from 8b7c87e to bc1790c Compare February 27, 2026 20:00

ssreerama marked this pull request as ready for review February 27, 2026 20:17

Copilot AI review requested due to automatic review settings February 27, 2026 20:17

ssreerama requested review from Benjin, aasimkhan30, allancascante, caohai, kburtram, laurenastrid1, lewis-sanchez and manujoseph85 as code owners February 27, 2026 20:17

Copilot started reviewing on behalf of ssreerama February 27, 2026 20:17 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Comment thread localization/xliff/sql-database-projects.xlf

Comment thread extensions/sql-database-projects/src/tools/buildHelper.ts

Comment thread extensions/sql-database-projects/src/common/httpClient.ts Outdated

ssreerama added 2 commits February 27, 2026 18:00

copilot suggestions

19a9aae

Merge branch 'main' into sai/mar/sqlproj_offlineDwnld_Issue

551bde8

Copilot AI review requested due to automatic review settings February 28, 2026 21:07

Copilot started reviewing on behalf of ssreerama February 28, 2026 21:07 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

Comment thread localization/xliff/sql-database-projects.xlf

Comment thread extensions/sql-database-projects/src/tools/buildHelper.ts

Comment thread extensions/sql-database-projects/src/common/httpClient.ts Outdated

Merge branch 'main' into sai/mar/sqlproj_offlineDwnld_Issue

aa6c69f

Benjin reviewed Mar 2, 2026

View reviewed changes

Comment thread extensions/sql-database-projects/src/common/constants.ts

Benjin reviewed Mar 2, 2026

View reviewed changes

Comment thread extensions/sql-database-projects/src/common/httpClient.ts Outdated

Benjin reviewed Mar 2, 2026

View reviewed changes

Comment thread extensions/sql-database-projects/test/httpClient.test.ts

Benjin requested changes Mar 2, 2026

View reviewed changes

moving the httpclient files to http folder

c0a454b

undo default timeouts for downloading

24b5269

Copilot AI review requested due to automatic review settings March 5, 2026 01:46

Copilot started reviewing on behalf of ssreerama March 5, 2026 01:49 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

more cleanup

dc07f05

ssreerama requested a review from Benjin March 5, 2026 18:54

Merge branch 'main' into sai/mar/sqlproj_offlineDwnld_Issue

61e5a6b

Copilot AI review requested due to automatic review settings March 5, 2026 19:08

Copilot AI reviewed Mar 5, 2026

View reviewed changes

test the nuget download on pipeline caused failure by extrazip

56aa28e

Benjin reviewed Mar 5, 2026

View reviewed changes

Comment thread extensions/mssql/src/http/httpClientCore.ts Outdated

Benjin reviewed Mar 5, 2026

View reviewed changes

Comment thread extensions/mssql/src/http/httpClientCore.ts

Benjin reviewed Mar 5, 2026

View reviewed changes

Comment thread extensions/sql-database-projects/src/tools/buildHelper.ts Outdated

cleanup

7e19227

ssreerama requested a review from Benjin March 6, 2026 16:26

changelog updates

2351fd0

Copilot AI review requested due to automatic review settings March 6, 2026 16:30

Copilot started reviewing on behalf of ssreerama March 6, 2026 16:31 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

ssreerama added 3 commits March 6, 2026 11:45

constant and comment updates

eea8f42

loc

a68325b

undo extractzip change and changelog

f3246f6

Copilot AI review requested due to automatic review settings March 6, 2026 20:48

Copilot started reviewing on behalf of ssreerama March 6, 2026 20:49 View session

changelog for only current PR fix

07c2901

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Benjin approved these changes Mar 6, 2026

View reviewed changes

ssreerama merged commit 2d83148 into main Mar 6, 2026
3 checks passed

ssreerama deleted the sai/mar/sqlproj_offlineDwnld_Issue branch March 6, 2026 21:24

ssreerama linked an issue Mar 9, 2026 that may be closed by this pull request

[Bug]: SQL Database Projects extension should not require NuGet access at build time #21385

Closed

17 tasks

Conversation

ssreerama commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Code Changes Checklist

Reviewers: Please read our reviewer guidelines

Uh oh!

github-actions Bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Changes

Uh oh!

codecov-commenter commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ssreerama commented Feb 26, 2026 •

edited

Loading

github-actions Bot commented Feb 26, 2026 •

edited

Loading

codecov-commenter commented Feb 27, 2026 •

edited

Loading