[dev-v5] Fix FluentTimePicker item generation logic and add unit tests#4890
Merged
Merged
Conversation
…ected time outputs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the Fluent UI (combobox) time-slot generation in FluentTimePicker so that the generated items correctly respect StartHour, EndHour, and Increment, and adds unit tests to validate the generated options (fixing #4889).
Changes:
- Updated the
Itemsgeneration formula inFluentTimePicker.razor.csto avoid producing times beyondEndHour. - Added a theory-based unit test that asserts option count plus first/last generated time strings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Core/Components/DateTime/FluentTimePicker.razor.cs |
Adjusts the item-generation logic for the dropdown time options. |
tests/Core/Components/DateTimes/FluentTimePickerTests.razor |
Adds tests asserting dropdown option count and first/last time values. |
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.7%
|
…al minutes and update test cases for expected outputs
vnbaaij
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix FluentTimePicker item generation logic and add unit tests
Correct the logic for generating time items in the FluentTimePicker component to ensure accurate outputs based on the specified start and end hours and increment.
Add unit tests to verify that the generated times match expected values.
Fix #4889