Add missing speech.context fields to match native SDK#1004
Open
rhurey wants to merge 2 commits into
Open
Conversation
Populate 6 fields in the speech.context message that the native C++ SDK sends but the JS SDK was missing: - phraseDetection.language (recognition language) - phraseDetection.initialSilenceTimeout - phraseDetection.trailingSilenceTimeout - phraseDetection.enrichment.profanity - phraseOutput.interimResults.stableThreshold - phraseDetection.enrichment.[mode].postprocessingoption (with truetext expansion) These were previously only sent as URL query parameters. They are now also sent in the speech.context JSON body, matching native SDK behavior. Existing URL query params are retained for backward compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
Resolve conflicts in: - ServiceMessages/PhraseDetection/ConversationEnrichmentOptions.ts - ServiceMessages/PhraseDetection/DictationEnrichmentOptions.ts - ServiceMessages/PhraseDetection/InteractiveEnrichmentOptions.ts - ServiceRecognizerBase.ts Keep PR's implementations for all new methods (setLanguageJson, setInitialSilenceTimeoutJson, setEndSilenceTimeoutJson, setProfanityOptionJson, setStableIntermediateThresholdJson) and use cleaner typed setPostProcessingOptionJson from PR, removing duplicate imports that the auto-merge added from master. Co-authored-by: rhurey <13647168+rhurey@users.noreply.github.com>
Merge conflicts resolved in commit 8299ac4. The conflicts were in 4 files where both branches had added the |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Populates 6 fields in the
speech.contextmessage that the native C++ SDK sends but the JS SDK was missing.Changes
New methods in ServiceRecognizerBase.ts:
Interface changes:
Design Decisions
ADO Work Item
Task #31645 in Speedme/Carbon