Cost Optimization VBD: Add Service Group filter to sub-template workbooks#3147
Open
arthurclares wants to merge 6 commits into
Open
Cost Optimization VBD: Add Service Group filter to sub-template workbooks#3147arthurclares wants to merge 6 commits into
arthurclares wants to merge 6 commits into
Conversation
- Merged 5 decision inbox entries into decisions.md (6 new decisions) - Added session log for v2 workbook assembly - Squad artifacts: agent charters/histories, ceremonies, routing, team config - Work done: 26 KQL queries with SG filters, complete workbook in 7 groups - All queries validated (26/26 pass), workbook structure validated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Service Group filtering support to the 6 sub-template workbooks referenced by the main Cost Optimization workbook. Each workbook's KQL queries now include a leftouter join against microsoft.relationships/servicegroupmember relationship resources, allowing users to scope results to a specific Service Group when the {ServiceGroup} parameter is set. When the parameter is empty, the filter is a no-op and all results are returned as before.
Modified workbooks:
AHB/AHB.workbook
Compute/Compute.workbook
Databases/Databases.workbook
Networking/Networking.workbook
Storage/Storage.workbook
Top10Services/Top10Services.workbook
The filter pattern appended to each query is:
| join kind=leftouter (relationshipresources | where type == 'microsoft.relationships/servicegroupmember' | where properties.TargetId =~ '{ServiceGroup}' | project _sgFilterId = tostring(properties.SourceId) | distinct _sgFilterId) on $left.<id> == $right._sgFilterId | where '{ServiceGroup}' == '' or isnotempty(_sgFilterId) | project-away _sgFilterIdScreenshots
If you added a template to a gallery, show a screenshot of it in the gallery view (which verifies its shows up where you expected).
It is also good to show a screenshot of template content, so people can see what you expect it to look like, compared to what they see when they might run it themselves.
Validation
Validate your changes using one or more of the testing methods.
Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!
Checklist
When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.