ReadyForRoomEvent#666
Open
stephen-derosa wants to merge 4 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: c972382 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Author
|
looks like my prettier stage is failing, i ran it locally but i see its unchanged -- maybe my local prettier format (default) is not what the repo uses? |
lukasIO
approved these changes
May 21, 2026
Contributor
lukasIO
left a comment
lukasIO
left a comment
There was a problem hiding this comment.
lgtm!
prettier should pick up the config from this repo, I pushed a fix (was just a import ordering issue), for next time you can try running pnpm run format:check and/or pnpm run format:write locally and it should work
ladvoc
approved these changes
May 21, 2026
Contributor
ladvoc
left a comment
ladvoc
left a comment
There was a problem hiding this comment.
LGTM ✅, thanks for adding this @stephen-derosa!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Send ReadyForRoomEventRequest once async connection is returned from rust.
Implications
Without this as of this commit in the rust SDK after fulfilling the async connection response, rust will timeout with a panic after 1s of not getting this request