Reveal Diagnostics from CodeLens#79
Merged
Merged
Conversation
CatarinaGamboa
approved these changes
May 18, 2026
Collaborator
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Cool! Quick question about the video, the scrolling only makes sense when we have the "show all errors" rather than the per file errors, right? Ig my question is more if it works for both the per file errors and all errors
Collaborator
Author
|
If the diagnostic is not visible because we are only showing the diagnostics for the current file, we automatically set |
rcosta358
commented
May 18, 2026
Comment on lines
+286
to
+289
| const isVisibleInCurrentFile = showAllDiagnostics || !target.file || target.file.toLowerCase() === currentFile?.toLowerCase(); | ||
| if (!isVisibleInCurrentFile) { | ||
| showAllDiagnostics = true; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a diagnostic CodeLens action that opens the LiquidJava webview, switches to the diagnostics explorer view, scrolls to the selected diagnostic, and highlights it. This also applies for failing refinements in the context debugger.
This allows users to easily map errors in the editor to their corresponding ones in the webview.
Screen.Recording.2026-05-16.at.20.06.40.mp4