LCORE-2295: Quota limiter configuration unit tests

[tisnik]

Description

LCORE-2295: Quota limiter configuration unit tests

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

• Assisted-by: N/A
• Generated by: N/A

Related Tickets & Documents

• Related Issue #LCORE-2295

Summary by CodeRabbit

Tests

• Enhanced test coverage for quota limiter configuration validation with additional negative test cases to ensure proper error handling and validation of invalid configurations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a016c572-8b04-45e2-9dc2-1d3067cab48c

📥 Commits

Reviewing files that changed from the base of the PR and between 6738771 and 746b638.

📒 Files selected for processing (1)

• tests/unit/models/config/test_quota_limiter_config.py

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: build-pr
• GitHub Check: E2E: server mode / ci / group 1
• GitHub Check: E2E: library mode / ci / group 3
• GitHub Check: E2E: library mode / ci / group 2
• GitHub Check: E2E: library mode / ci / group 1
• GitHub Check: E2E: server mode / ci / group 3
• GitHub Check: E2E: server mode / ci / group 2
• GitHub Check: E2E Tests for Lightspeed Evaluation job
• GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request

🧰 Additional context used

📓 Path-based instructions (1)

tests/**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

tests/**/*.py: Use pytest for all unit and integration tests; do not use unittest
Use pytest.mark.asyncio marker for async tests

Files:

• tests/unit/models/config/test_quota_limiter_config.py

🔇 Additional comments (1)

tests/unit/models/config/test_quota_limiter_config.py (1)

319-409: LGTM!

---

Walkthrough

This PR extends the quota limiter configuration test suite by adding negative test cases. It introduces an incorrect_configurations fixture containing various invalid configuration dictionaries and a parametrized test that verifies each configuration raises a ValueError during QuotaLimiterConfiguration instantiation.

Changes

Quota Limiter Negative Case Testing

Layer / File(s)	Summary
Invalid configuration test fixture and validation tests/unit/models/config/test_quota_limiter_config.py	incorrect_configurations list provides invalid config dictionaries with wrong types, None fields, and non-numeric values; parametrized test test_configure_quota_handlers_from_dict_negative_cases verifies each raises ValueError matching "validation error".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding unit tests for quota limiter configuration, which directly matches the PR's focus on test improvements.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

✨ Simplify code

• Create PR with simplified code

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}