EXSC-301 Deploy Arc mainnet core setup#1846
Conversation
lifi-action-bot
changed the title
|
Warning Review limit reached
More reviews will be available in 8 minutes and 51 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
WalkthroughThis PR adds ARC network support across configuration and deployment artifacts and refactors PolymerCCTPFacet to store chainId→domainId mappings in diamond storage with owner-initialized init/set/get APIs; deployment scripts now load mappings from config JSON. ChangesARC Network Support and PolymerCCTPFacet Refactor
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Coverage ReportLine Coverage: 89.90% (3223 / 3585 lines) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/Facets/PolymerCCTPFacet.sol`:
- Line 19: The contract was bumped to version 3.0.0 but the audit metadata
consumed by VersionControlAndAuditVerification lacks a matching entry; add an
audit record for PolymerCCTPFacet v3.0.0 in the same structure used by the
existing audit metadata (e.g., the auditEntries/auditRecords array or
getAuditRecords/getAuditMetadata function), using the same field names and types
(version, contractName "PolymerCCTPFacet", auditor, date, reportHash/signature
or URL) so the new entry exactly mirrors the format of prior records and will be
recognized by VersionControlAndAuditVerification.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 57b5f08b-1d5d-497c-be07-13ebaba4cc06
📒 Files selected for processing (12)
config/networks.jsonconfig/permit2Proxy.jsonconfig/polymercctp.jsonconfig/whitelist.jsondeployments/arc.diamond.jsondeployments/arc.jsondocs/PolymerCCTPFacet.mdfoundry.tomlscript/deploy/_targetState.jsonscript/deploy/facets/UpdatePolymerCCTPFacet.s.solsrc/Facets/PolymerCCTPFacet.soltest/solidity/Facets/PolymerCCTPFacet.t.sol
| /// @author LI.FI (https://li.fi) | ||
| /// @notice Provides functionality for bridging USDC through Polymer CCTP | ||
| /// @custom:version 2.0.1 | ||
| /// @custom:version 3.0.0 |
There was a problem hiding this comment.
Add the missing audit record for PolymerCCTPFacet v3.0.0.
Line 19 bumps the facet to 3.0.0, but CI fails because no matching audit entry is logged for this version. Please add/update the audit metadata consumed by VersionControlAndAuditVerification so this upgrade can pass release gates.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/Facets/PolymerCCTPFacet.sol` at line 19, The contract was bumped to
version 3.0.0 but the audit metadata consumed by
VersionControlAndAuditVerification lacks a matching entry; add an audit record
for PolymerCCTPFacet v3.0.0 in the same structure used by the existing audit
metadata (e.g., the auditEntries/auditRecords array or
getAuditRecords/getAuditMetadata function), using the same field names and types
(version, contractName "PolymerCCTPFacet", auditor, date, reportHash/signature
or URL) so the new entry exactly mirrors the format of prior records and will be
recognized by VersionControlAndAuditVerification.
Add Arc mainnet (5042) network config, deployment logs, and target state. Depends on PolymerCCTPFacet v3.0.0 (EXSC-254) for CCTP domain mapping. EXSC-301 Co-authored-by: Cursor <cursoragent@cursor.com>
0xDEnYO
force-pushed
the
feature/exsc-301-sc-deploy-sc-core-setup
branch
from
8eeec7b to
1fdb6f7
Compare
0xDEnYO
changed the title
Depends on EXSC-254 merge before Arc deploy uses this version. Co-authored-by: Cursor <cursoragent@cursor.com>
2 participants
Which Linear task belongs to this PR?
https://linear.app/lifi-linear/issue/EXSC-301/sc-deploy-sc-core-setup
Why did I implement it this way?
Deploys the LI.FI diamond and periphery contracts on Arc mainnet (chainId
5042). Config, deployment logs, and target state only — no facet code changes.Depends on: EXSC-254 /
PolymerCCTPFacetv3.0.0 for dynamic CCTP domain mappings. Merge and deploy the facet upgrade before (or as part of) Arc Polymer CCTP go-live.Arc has no GasZip support (USDC is native gas). CCTP is the only live bridge at launch.
Checklist before requesting a review
/pr-ready(local CodeRabbit) on this branch and resolved (or explicitly documented) all findings — see.agents/commands/pr-ready.mdChecklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)