Skip to content

feat(api): update API spec from langfuse/langfuse 632aafa#1679

Open
langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-632aafa
Open

feat(api): update API spec from langfuse/langfuse 632aafa#1679
langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-632aafa

Conversation

@langfuse-bot
Copy link
Copy Markdown
Collaborator

@langfuse-bot langfuse-bot commented May 29, 2026

Greptile Summary

This PR updates the docstring description of the matches operator across the observations API client files to reflect a behavior change in how the operator works — from "token-based full-text search" to "indexed literal search with token-boundary pruning."

  • The description of input and output filter fields is updated from "accelerated token search" to "accelerated indexed literal search" in all four client classes (ObservationsClient, AsyncObservationsClient, RawObservationsClient, AsyncRawObservationsClient).
  • The operator's prose explanation is expanded to clarify that % and _ are treated as literal characters (not SQL LIKE wildcards) and that contains is now described as offering "legacy substring semantics."

Confidence Score: 5/5

This PR is safe to merge — all changes are confined to docstrings and introduce no runtime behavior modifications.

All four changed hunks are docstring updates describing how the matches operator works. No function signatures, logic, or data flow is altered. The updated text is consistent across both the sync and async variants of the two client modules.

No files require special attention.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant ObservationsClient
    participant API as Langfuse API

    Caller->>ObservationsClient: "get_many(filter=[{column:"input", operator:"matches", value:"..."}])"
    Note over ObservationsClient: Validates filter params<br/>(v2: must pair matches/= with input/output)
    ObservationsClient->>API: "GET /api/public/observations?filter=..."
    API-->>ObservationsClient: ObservationsViews (paginated)
    ObservationsClient-->>Caller: ObservationsViews
Loading

Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile

@langfuse-bot langfuse-bot requested a review from sumerman May 29, 2026 09:12
@github-actions
Copy link
Copy Markdown

@claude review

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — docstring-only update in auto-generated Fern API client.

Extended reasoning...

Overview

This PR updates docstrings in two auto-generated Fern API client files (langfuse/api/observations/client.py and langfuse/api/observations/raw_client.py). The changes only modify the description of the matches filter operator — from "accelerated token search / token-based full-text search" to "accelerated indexed literal search with token-boundary pruning", and add a clarifying note that % and _ are treated as literal characters (unlike SQL LIKE).

Security risks

None. No executable code paths, parameters, request bodies, or auth logic are touched. The diff is confined to docstring text inside generated client methods.

Level of scrutiny

Minimal. This is a routine API-spec regeneration (feat(api): update API spec from langfuse/langfuse 632aafa) that touches only auto-generated documentation strings. The repo already has prior commits of this exact form on main.

Other factors

No bugs were flagged by the bug hunting system. The four updated docstrings (sync + async × client + raw_client) are consistent with each other. Nothing here warrants human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant