fix: mobile alignment for homepage feature blocks#103
Conversation
|
@khushal-winner is attempting to deploy a commit to the Ketan's Personal Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Warning
|
| Cohort / File(s) | Summary |
|---|---|
Layout alignment components/value-blocks.tsx |
Replaced right-aligned/off-center utility classes with centered alignment (items-center, text-center, etc.) on primary and nested containers; adjusted heading/paragraph alignment and line-wrapping. No API, export, or logic changes. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
🐰 I hopped along the layout trees,
Centered text now sways with ease,
Mobile hums a balanced tune,
Blocks align beneath the moon,
Joyful hops — a neat UX breeze ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and specifically describes the main change: fixing mobile alignment for homepage feature blocks, which aligns with the changeset's focus on layout adjustments. |
| Description check | ✅ Passed | The description includes all required sections (Summary, Testing, Checklist) with before/after screenshots demonstrating the fix and addresses the linked issue #98. |
| Linked Issues check | ✅ Passed | The PR successfully addresses issue #98 by fixing mobile alignment of the four feature text blocks through layout adjustments (centering text and content), meeting the stated requirement. |
| Out of Scope Changes check | ✅ Passed | All changes are narrowly scoped to fixing mobile alignment through layout modifications (adding items-center, text-center classes) with no unrelated refactors or structural changes introduced. |
| Docstring Coverage | ✅ Passed | Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@components/value-blocks.tsx`:
- Line 62: The left-image blocks aren't applying large-screen left alignment;
update the className on the container divs in PreviousEditionsBlock and
AnalyticsBlock (the divs currently using "flex gap-4 flex-col flex-1
items-center text-center") to include the large-screen overrides "lg:items-start
lg:text-left" so they mirror the right-image blocks' desktop behavior; ensure
both occurrences in PreviousEditionsBlock and AnalyticsBlock are changed.
- Add lg:items-start lg:text-left to PreviousEditionsBlock container - Add lg:items-start lg:text-left to AnalyticsBlock container - Ensures left-image blocks mirror right-image blocks' desktop behavior - Maintains mobile centering while adding proper desktop left alignment
- Add lg:text-right to OrganizationsBlock and TechStackBlock inner divs - Add lg:text-left to PreviousEditionsBlock and AnalyticsBlock inner divs - Ensures proper desktop alignment: right-image blocks right-align, left-image blocks left-align - All blocks maintain mobile centering with consistent responsive behavior
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ketankauntia
left a comment
There was a problem hiding this comment.
Great work @khushal-winner
|
i feel this has already been resolved by you in #104 and hence i am closing this. |
Summary
fix: mobile alignment for homepage feature blocks
Testing
closes: #98
Checklist
Summary by CodeRabbit