Fix crash when loading old checkpoints with -reset_iterations 0 flag#88
Open
ChrisCummins wants to merge 1 commit into
Open
Fix crash when loading old checkpoints with -reset_iterations 0 flag#88ChrisCummins wants to merge 1 commit into
-reset_iterations 0 flag#88ChrisCummins wants to merge 1 commit into
Conversation
Using `-reset_iterations 0` when initialising training from a checkpoint made before commit 6990602 causes an error, as reported in issue jcjohnson#82. This patch adds a backwards compatibility fix. For checkpoint files which do not contain the iteration counter, a warning is printed on checkpoint load and training continues as if not flag was given: $ th train.lua $OPTIONS -init_from cv/checkpoint_10.t7 -reset_iterations 0 Running in CPU mode Initializing from cv/checkpoint_10.t7 reset_iterations: cv/checkpoint_10.t7 contains no iteration counter Epoch 1.00 / 50, i = 1 / 17800, loss = 3.474951 Epoch 1.01 / 50, i = 2 / 17800, loss = 3.344084 ... The behaviour for checkpoints which do contain an iteration counter is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
-reset_iterations 0when initialising training from a checkpoint made before commit 6990602 causes an error, as reported in issue #82. This patch adds a backwards compatibility fix.For checkpoint files which do not contain the iteration counter, a warning is printed on checkpoint load and training continues as if not flag was given:
The behaviour for checkpoints which do contain an iteration counter is unaffected.