[AMDGPU] fix Coverity issues#22060
Open
bratpiorka wants to merge 1 commit into
Open
Conversation
sarnex
reviewed
May 19, 2026
Contributor
There was a problem hiding this comment.
Should these changes go upstream?
YuriPlyakhin
requested changes
May 19, 2026
Contributor
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
There was a problem hiding this comment.
we should not modify AMDGPU target code downstream. If this a real problem, it should go upstream.
Contributor
Author
|
@sarnex @YuriPlyakhin I understand and agree with you but this is per Pallavi / Thorsten / Ashbaugh request. Here is the upstream PR: llvm/llvm-project#198570 |
Contributor
@bratpiorka , what was exactly the request? Maybe we should discuss in a call... |
bratpiorka
force-pushed
the
rrudnick_coverity_x
branch
from
be35300 to
bbc0b4f
Compare
Contributor
Author
|
@sarnex @YuriPlyakhin upstream PR llvm/llvm-project#198570 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix Coverity issues 3493587 and 3498634
upstream PR: llvm/llvm-project#198570