Support string for transition/backgroundTransition#3899
Open
tjenkinson wants to merge 2 commits into
Open
Conversation
The `& {}` is so that autocomplete still works for the other options
There was a problem hiding this comment.
Pull request overview
Extends the RevealConfig transition option typings so transition and backgroundTransition can accept custom transition names (strings), enabling custom CSS transition class usage while keeping literal autocomplete.
Changes:
- Broadened
TransitionStyleto include arbitrary string values via the(string & {})autocomplete-preserving pattern.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing custom transitions in css I am passing a custom name here, which does go through to the class.
So I think it makes sense to support
stringin the types?The
& {}is so that autocomplete still works for the other options