CNN PR [3/4]: Add LCSC CNN model#895
Draft
sevmag wants to merge 2 commits into
Draft
Conversation
Introduce `graphnet.models.cnn`, the convolutional-network counterpart to the existing GNN backbones, intended to consume the image data representation added in the image-representation PR. - `CNN` — abstract base class (analogue of `GNN`) defining the interface for convolutional backbones operating on image-shaped `Data` objects. - `IceCubeDNN` — configurable CNN backbone following the IceCube DNN reconstruction architecture. `cnn/__init__.py` exports `CNN` and `IceCubeDNN`; the `LCSC` model lands in a follow-up PR. Split from graphnet-team#813.
Add the LCSC convolutional backbone, building on the `CNN` base class. Registered in `cnn/__init__.py` alongside `CNN` and `IceCubeDNN`. Stacked on the CNN-base PR. Split from graphnet-team#813.
Draft
sevmag
changed the title
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fourth in the series of PRs being carved out of #813 (see the split tracking comment). Adds the LCSC convolutional backbone, building on the
CNNbase class from #894.What's new
LCSC— convolutional model subclassingCNN(src/graphnet/models/cnn/lcsc.py).LCSCincnn/__init__.pyalongsideCNNandIceCubeDNN.This branch is stacked on top of #894 (CNN base + IceCubeDNN). Because the base branch only exists in the fork, this PR targets
maindirectly, so its current diff includes #894's files (cnn.py,icecube_dnn.py) as well as the net-newlcsc.py. Once #894 is merged intomain, GitHub will automatically narrow this diff to justlcsc.py+ the one-line__init__.pychange.Review/merge order: review #894 first; this PR is kept as a draft until #894 lands, then it'll be marked ready.
Test plan
black,flake8,docformatter,pydocstyle,mypy, EOL/whitespace)from graphnet.models.cnn import CNN, IceCubeDNN, LCSCsucceedsSplit from #813.
🤖 Generated with Claude Code