fix: preserve live thinking config#5812
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Collaborator
|
Response from ADK Triaging Agent Hello @he-yufeng, thank you for creating this PR! This PR is a bug fix, and while you have provided a detailed "To verify" section, could you please also:
This information will help our reviewers review your PR more efficiently. Thanks! |
40f5ae3 to
eb4aa44
Compare
Author
|
Rebased this branch onto current Validation on Windows: The warnings are the existing experimental feature warnings from this test file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenerateContentConfig.thinking_configinto the Gemini live connect configaio.live.connect()receives the thinking configTo verify
uv run pytest tests/unittests/models/test_google_llm.py -quv run pyink --check src/google/adk/models/google_llm.py tests/unittests/models/test_google_llm.pypython -m py_compile C:\dev\GITHUB-clean\adk-python\src\google\adk\models\google_llm.py C:\dev\GITHUB-clean\adk-python\tests\unittests\models\test_google_llm.pygit diff --check -- src/google/adk/models/google_llm.py tests/unittests/models/test_google_llm.pyFixes #5805