fix: preserve live session transparency#5773
Conversation
|
Response from ADK Triaging Agent Hello @he-yufeng, thank you for creating this PR! We appreciate your contribution to fixing the live session transparency issue. To help our reviewers process your PR faster, could you please provide the following details in accordance with our Contribution Guidelines:
This information will help reviewers verify and merge your PR more efficiently. Thank you! |
85be979 to
d5ee97c
Compare
|
Rebased onto current Local results on the branch:
Note: the full local |
d5ee97c to
533a727
Compare
|
Rebased again onto current Validation on Windows: The warning is the existing experimental |
533a727 to
a985d5b
Compare
|
Rebased onto current upstream/main again after the branch went behind.\n\nValidation on Windows after rebase:\n- uv run --no-sync pytest tests\unittests\flows\llm_flows\test_base_llm_flow.py -q --basetemp .tmp\pytest-5773-20260524 -p no:cacheprovider -> 30 passed, 1 warning\n- uv run --no-sync python -m py_compile src\google\adk\flows\llm_flows\base_llm_flow.py tests\unittests\flows\llm_flows\test_base_llm_flow.py\n- uv run --no-sync pyink --check src\google\adk\flows\llm_flows\base_llm_flow.py tests\unittests\flows\llm_flows\test_base_llm_flow.py\n- git diff --check upstream/main..HEAD\n\nThe warning is the existing experimental JSON_SCHEMA_FOR_FUNC_DECL warning from this test file. |
Summary
session_resumption.transparent = Truewhenrun_live()reconnects with a saved handleTo verify
.\.venv\Scripts\python.exe -m pytest tests\unittests\flows\llm_flows\test_base_llm_flow.py::test_run_live_reconnects_on_connection_closed tests\unittests\flows\llm_flows\test_base_llm_flow.py::test_run_live_reconnects_on_api_error tests\unittests\flows\llm_flows\test_base_llm_flow.py::test_run_live_skips_send_history_on_resumption tests\unittests\flows\llm_flows\test_base_llm_flow.py::test_live_session_resumption_go_away tests\unittests\flows\llm_flows\test_base_llm_flow.py::test_run_live_no_reconnect_without_handle tests\unittests\flows\llm_flows\test_base_llm_flow.py::test_run_live_reconnect_limit tests\unittests\flows\llm_flows\test_base_llm_flow.py::test_run_live_reconnect_reset_attempt -q.\.venv\Scripts\python.exe -m pyink --check src\google\adk\flows\llm_flows\base_llm_flow.py tests\unittests\flows\llm_flows\test_base_llm_flow.py.\.venv\Scripts\python.exe -m py_compile src\google\adk\flows\llm_flows\base_llm_flow.py tests\unittests\flows\llm_flows\test_base_llm_flow.pygit diff --checkFixes #5771