Skip to content

ref(node): Vendor dataloader instrumentation#20950

Draft
nicohrubec wants to merge 1 commit into
developfrom
nh/vendor-dataloader-instrumentation
Draft

ref(node): Vendor dataloader instrumentation#20950
nicohrubec wants to merge 1 commit into
developfrom
nh/vendor-dataloader-instrumentation

Conversation

@nicohrubec
Copy link
Copy Markdown
Member

Vendors @opentelemetry/instrumentation-dataloader into the SDK with no logic changes.

Closes #20146

Closes #20146

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4745e1f. Configure here.

@@ -1,4 +1,4 @@
import { DataloaderInstrumentation } from '@opentelemetry/instrumentation-dataloader';
import { DataloaderInstrumentation } from './vendored/instrumentation';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing sentry.op for new vendored span types

Low Severity

The vendored instrumentation was upgraded from v0.31.0 to v0.35.0, which adds prime, clear, and clearAll span types that the old version didn't create. The integration code's spanStart hook correctly sets SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN for all dataloader spans (via startsWith), but only sets SEMANTIC_ATTRIBUTE_SENTRY_OP for load, loadMany, and batch. The new spans lack an op attribute. The stale comment at line 40–42 even anticipated this scenario. Appropriate ops exist in the codebase (cache.put, cache.remove, cache.flush) and would apply to prime, clear, and clearAll respectively.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 4745e1f. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vendor @opentelemetry/instrumentation-dataloader

1 participant