chore(build): Replace sucrase with esbuild#20865
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8dc63cf. Configure here.
mydea
force-pushed
the
feat/replace-sucrase
branch
2 times, most recently
from
d6f4a1c to
6c34c49
Compare
andreiborza
approved these changes
May 18, 2026
Member
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
Nice, especially the cf reduction where we should be size conscious as well!
Overall LGTM, but the lockfile is out of date.
mydea
force-pushed
the
feat/replace-sucrase
branch
from
6c34c49 to
1733788
Compare
JPeer264
approved these changes
May 18, 2026
Lms24
approved these changes
May 18, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
LGTM! I think getting rid of sucrase is a good idea, given it never really took off and esbuild is more widely used for transpiling.
| "deepmerge": "^4.2.2", | ||
| "downlevel-dts": "~0.11.0", | ||
| "es-check": "^7.2.1", | ||
| "esbuild": "^0.28.0", |
Member
There was a problem hiding this comment.
q: I'm probably missing something but why do we need esbuild explicitly? I don't see it being imported (as opposed to rollup-plugin-esbuild) .
Member
Author
There was a problem hiding this comment.
it is a peerDependency! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates our rollup config to use esbuild instead of sucrase/typescript plugins.
Doing this, required a few changes to our rollup plugin setup, which all should be generally good changes IMHO:
Overall bundle size seems stable, slight reductions in a few places - execpt for cloudflare, which actually has a 3.5kb reduction for whatever reason.