fix: fixes error screen not being shown bug

[pandeymangg]

fixes https://linear.app/formbricks/issue/ENG-1011/

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Walkthrough

The SurveyWebView component relocates two placeholder callback definitions for response-sending completion and error signaling. Previously, getSetIsResponseSendingFinished was passed as a native-side option to renderHtml. The change removes this from native options and instead defines both getSetIsResponseSendingFinished and getSetIsError as noop functions directly within the HTML script's surveyProps object passed to the embedded Formbricks library.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: fixes error screen not being shown bug' directly relates to the main change, which is fixing the error screen display functionality in the SurveyWebView component by properly defining error-handling callbacks.
Description check	✅ Passed	The description references a specific Linear issue (ENG-1011) and includes a screenshot showing the error dialog that was not being displayed, which relates to the changeset's purpose of fixing error screen visibility.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/react-native/src/components/survey-web-view.tsx`:
- Around line 371-382: Add a small Vitest unit test that asserts renderHtml(...)
(or the function that returns the WebView HTML used by loadSurvey) includes both
injected callback placeholders for getSetIsResponseSendingFinished and
getSetIsError so they can't be dropped by accident; specifically call renderHtml
or the helper that produces the HTML used by loadSurvey, then assert the
returned string contains the expected identifiers (e.g.,
"getSetIsResponseSendingFinished" and "getSetIsError" or their exact placeholder
signatures) and any surrounding call/assignment pattern your runtime expects,
failing the test if either is missing.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d9f4f1ba-db34-4f1b-9614-6e055c06267a

📥 Commits

Reviewing files that changed from the base of the PR and between 5427fdc and 16a5d9a.

📒 Files selected for processing (1)

• packages/react-native/src/components/survey-web-view.tsx