Skip to content

Address utf8 support when uploading JavaScript application#4364

Open
bekindpleaserewind wants to merge 1 commit into
flipperdevices:devfrom
bekindpleaserewind:bugfix/issue-4363
Open

Address utf8 support when uploading JavaScript application#4364
bekindpleaserewind wants to merge 1 commit into
flipperdevices:devfrom
bekindpleaserewind:bugfix/issue-4363

Conversation

@bekindpleaserewind
Copy link
Copy Markdown

What's new

  • fz-sdk - address a bug in issue # 4363 causing characters to continue on to the beginning of the js command when writing utf8 files to the device.

Verification

Note index.ts should be a larger typescript utf-8 file.

With updated changes

$ file index.ts
index.ts: JavaScript source, Unicode text, UTF-8 text

$ file dist/automarauder.js 
dist/automarauder.js: JavaScript source, Unicode text, UTF-8 text

$ npx npm run start

> automarauder@1.0.0 start
> npm run build && node node_modules/@next-flip/fz-sdk-mntm/sdk.js upload


> automarauder@1.0.0 build
> tsc && node node_modules/@next-flip/fz-sdk-mntm/sdk.js build

Connecting to Flipper at /dev/ttyACM0
Uploading application file
Launching application
Running script /ext/apps/Scripts/automarauder.js, press CTRL+C to stop
main

Checklist (For Reviewer)

  • [ x ] PR has description of feature/bug or link to Confluence/Jira task
  • [ x ] Description contains actions to verify feature/bugfix
  • [ x ] I've built this code, uploaded it to the device and verified feature/bugfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant