Fix Test::Future::Deferred weak lifetime handling#833
Merged
Conversation
Fix reference ownership and closure capture cases exposed by Test::Future::Deferred. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
Preserve captured scalar slots in bytecode-interpreter lexical assignments so closures and lvalue subs continue to alias the live lexical. Route bytecode-interpreter assignments to `our` scalars through the declaring package global, matching interpreter reads. Add interpreter-forced regression coverage for the captured lexical and `our` scalar assignment failures found in PR #833. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
75c64a6 to
9203c28
Compare
Inline the small Sub::Quote/Sub::Defer behavior needed by the regression test so CI unit tests do not depend on locally installed CPAN modules. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unit coverage
Testing
timeout 1200 maketimeout 600 jperl -Iblib/lib -Iblib/arch t/01future-pp.tin Future-0.52 buildtimeout 600 jperl -Iblib/lib -Iblib/arch t/02cancel-pp.tin Future-0.52 buildtimeout 7200 ./jcpan -t Test::Future::Deferredtimeout 7200 ./jcpan -t Mootimeout 7200 ./jcpan -t DBIx::Classpassed on rerun (Files=314, Tests=13120, Result: PASS)Note: an earlier DBIx::Class full run had a one-off TAP harness no-output timeout in
t/sqlmaker/bind_transport.t; the file passed directly in 9s and the full DBIx::Class rerun passed.