Allow setting the local P2 cache dir in the Spotless Gradle plugin#2944
Open
bric3 wants to merge 2 commits into
Open
Allow setting the local P2 cache dir in the Spotless Gradle plugin#2944bric3 wants to merge 2 commits into
bric3 wants to merge 2 commits into
Conversation
bric3
commented
May 21, 2026
Contributor
|
Maybe the Gradle plug-in could also set a more sensible default? |
Contributor
|
Somewhere inside |
Contributor
Author
|
I hesitated to do that, as it's a breaking change. |
Contributor
|
IMHO, if we just break a potentially existing cache, it's not so much of an issue. But maybe you're right. 🤷🏼♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a way to control in which directory the Eclipse based formatters will be cached. This PR adds a
cacheDirectorymethod in the config of each Eclipse based steps.The reason is that, by default the eclipse resolver will place the downloaded artifacts in
~/.m2/repository/dev/equo/p2-data, this folder is a bit alien in Gradle based build. And having it nested in the maven repository structure makes it a bit harder to manage in a CI.Given it's a Gradle related change, I choose to not add this under the maven plugin since
.m2/is already maven managed.