Skip to content

add the ajaxSetter option#549

Closed
eiro wants to merge 1 commit into
devbridge:masterfrom
eiro:master
Closed

add the ajaxSetter option#549
eiro wants to merge 1 commit into
devbridge:masterfrom
eiro:master

Conversation

@eiro
Copy link
Copy Markdown

@eiro eiro commented Oct 27, 2016

provide a way to rearange the settings of the ajax request just before
sending the request.

there is no doc, no test and and it introduce at least one bug we need to talk about. (https://github.com/eiro/eiro.github.com/blob/master/notes/jquery-autocomplete.md) i i saw now developper mailing list. if you're interested, i'm eiro on freenode too.

regards

provide a way to rearange the settings of the ajax request just before
sending the request.
@Shnoulle
Copy link
Copy Markdown

We can not use included function for this ?

        beforeSend : function(jqXHR, settings) {
                // Update your settings here
            }
        },

I already used it with success.

@tkirda
Copy link
Copy Markdown
Member

tkirda commented May 20, 2026

Thanks for this contribution, and apologies for the very long silence.

The project was dormant for several years and has just shipped v2.0, which is a ground-up TypeScript rewrite with a new build (esbuild), test runner (Vitest + jsdom), and CI pipeline. As a result this PR no longer applies cleanly against master, and the surrounding code it touches has changed enough that mechanically rebasing it wouldn't be safe.

I'm closing it as part of a triage pass on the long-stale PR backlog — not because the idea lacks merit. If this change is still valuable to you against 2.0, please open a fresh PR (or an issue first if you'd like to confirm direction); I'll review new submissions against the current codebase promptly.

Thanks again for taking the time.

@tkirda tkirda closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants