ShowNoSuggestionNotice can be a function. Fix of noSuggestionNotice.#341
ShowNoSuggestionNotice can be a function. Fix of noSuggestionNotice.#341glowka wants to merge 1 commit into
Conversation
happyrobotstudio
left a comment
There was a problem hiding this comment.
This would be really useful to be able to use a function on no results =)
|
Thanks for this contribution, and apologies for the very long silence. The project was dormant for several years and has just shipped v2.0, which is a ground-up TypeScript rewrite with a new build (esbuild), test runner (Vitest + jsdom), and CI pipeline. As a result this PR no longer applies cleanly against I'm closing it as part of a triage pass on the long-stale PR backlog — not because the idea lacks merit. If this change is still valuable to you against 2.0, please open a fresh PR (or an issue first if you'd like to confirm direction); I'll review new submissions against the current codebase promptly. Thanks again for taking the time. |
Hey there.
I added option to specify function as showNoSuggestionNotice. It's helpful when there is need to dynamically decide weather to display noSuggestionNotice or not. The function takes suggestions as only argument, thanks to that You can decide to show notice when e.g suggestions are shorter than 3.