Skip to content

ShowNoSuggestionNotice can be a function. Fix of noSuggestionNotice.#341

Closed
glowka wants to merge 1 commit into
devbridge:masterfrom
glowka:master
Closed

ShowNoSuggestionNotice can be a function. Fix of noSuggestionNotice.#341
glowka wants to merge 1 commit into
devbridge:masterfrom
glowka:master

Conversation

@glowka
Copy link
Copy Markdown
Contributor

@glowka glowka commented Mar 29, 2015

Hey there.
I added option to specify function as showNoSuggestionNotice. It's helpful when there is need to dynamically decide weather to display noSuggestionNotice or not. The function takes suggestions as only argument, thanks to that You can decide to show notice when e.g suggestions are shorter than 3.

Copy link
Copy Markdown

@happyrobotstudio happyrobotstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be really useful to be able to use a function on no results =)

@tkirda
Copy link
Copy Markdown
Member

tkirda commented May 20, 2026

Thanks for this contribution, and apologies for the very long silence.

The project was dormant for several years and has just shipped v2.0, which is a ground-up TypeScript rewrite with a new build (esbuild), test runner (Vitest + jsdom), and CI pipeline. As a result this PR no longer applies cleanly against master, and the surrounding code it touches has changed enough that mechanically rebasing it wouldn't be safe.

I'm closing it as part of a triage pass on the long-stale PR backlog — not because the idea lacks merit. If this change is still valuable to you against 2.0, please open a fresh PR (or an issue first if you'd like to confirm direction); I'll review new submissions against the current codebase promptly.

Thanks again for taking the time.

@tkirda tkirda closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants