Skip to content

Fix empty response#337

Closed
SunboX wants to merge 2 commits into
devbridge:masterfrom
SunboX:fix-empty-response
Closed

Fix empty response#337
SunboX wants to merge 2 commits into
devbridge:masterfrom
SunboX:fix-empty-response

Conversation

@SunboX
Copy link
Copy Markdown
Contributor

@SunboX SunboX commented Mar 24, 2015

Ignore empty response suggestions and try to fetch again. The server may return empty responses, because it starts searching only if a string of min-length of 3 chars is given (to avoid huge responses).

@tkirda
Copy link
Copy Markdown
Member

tkirda commented May 20, 2026

Thanks for this contribution, and apologies for the very long silence.

The project was dormant for several years and has just shipped v2.0, which is a ground-up TypeScript rewrite with a new build (esbuild), test runner (Vitest + jsdom), and CI pipeline. As a result this PR no longer applies cleanly against master, and the surrounding code it touches has changed enough that mechanically rebasing it wouldn't be safe.

I'm closing it as part of a triage pass on the long-stale PR backlog — not because the idea lacks merit. If this change is still valuable to you against 2.0, please open a fresh PR (or an issue first if you'd like to confirm direction); I'll review new submissions against the current codebase promptly.

Thanks again for taking the time.

@tkirda tkirda closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants