feat(wallet): implement Maya sell convert and order preview flow#772
feat(wallet): implement Maya sell convert and order preview flow#772romchornyi wants to merge 48 commits into
Conversation
- Export CSV - Zenledger Changed the navigation bar for sheet "Import private key"
This reverts commit 527ebef.
…to feat/update-csv-export-and-zenledger
Update 21 language files and Japanese App Store metadata from Transifex. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chore: pull latest translations from Transifex (50%+ complete)
…dger feat: update csv export and zenledger
…gation - Migrate all menu items to use the new MenuItem component - Update styles for MenuItemsList - Replace all menu item icons with updated assets - Change "Buy & Sell Dash" and "Explore" from bottom sheet to full page
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
feat: Update menu items on the More page
…to fix/support-iOS-26
fix: support iOS 26
…-mode fix: default currency dark mode and search empty state (MO-897)
fix: update translations and fix compile issue
…address selection
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR updates the DashWallet app's build configuration and completely reorganizes its asset catalog. Changes include updating the sync commit hash, switching the Xcode scheme to Debug mode, adding preview detection to AppDelegate, and restructuring/renaming image assets across menu, navigation, toast, illustration, and other UI categories. ChangesApp Configuration and Launch
Asset Catalog Reorganization
🎯 2 (Simple) | ⏱️ ~10 minutes Possibly Related PRs
Suggested Reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
🧹 Nitpick comments (3)
DashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-back.imageset/Contents.json (1)
52-55: ⚡ Quick winAlign toolbar-back with template rendering intent used by other toolbar icons.
toolbar-close.imagesetalready declares template intent; adding it here keeps toolbar icon tint behavior consistent.Based on learnings: “set template-rendering-intent to 'template' for generic/system UI icons that should inherit the system tint.”Proposed update
"info" : { "author" : "xcode", "version" : 1 + }, + "properties" : { + "template-rendering-intent" : "template" } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@DashWallet/Resources/AppAssets.xcassets/Navigation` bar/toolbar-back.imageset/Contents.json around lines 52 - 55, The Contents.json for the toolbar-back.imageset is missing the template rendering intent used by other toolbar icons; update the Contents.json inside toolbar-back.imageset to include the "template-rendering-intent" key with the value "template" (matching toolbar-close.imageset) so the toolbar-back asset will inherit system tinting as a template image.DashWallet/Resources/AppAssets.xcassets/Navigation bar/controls-info.imageset/Contents.json (1)
19-23: ⚡ Quick winAdd template rendering intent for this navigation icon imageset.
For UI control icons, explicitly setting template rendering intent avoids tint mismatches across themed screens.
Based on learnings: “set template-rendering-intent to 'template' for generic/system UI icons that should inherit the system tint.”Proposed update
"info" : { "author" : "xcode", "version" : 1 + }, + "properties" : { + "template-rendering-intent" : "template" } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@DashWallet/Resources/AppAssets.xcassets/Navigation` bar/controls-info.imageset/Contents.json around lines 19 - 23, The imageset "controls-info.imageset" (the "info" entry in Contents.json) lacks a template rendering intent; update its Contents.json to add the "template-rendering-intent" key with value "template" for the "info" image so the icon inherits system tint (i.e., set "template-rendering-intent": "template" for the "info" imageset entry).DashWallet/Resources/AppAssets.xcassets/Navigation bar/controls-template.imageset/Contents.json (1)
19-23: ⚡ Quick winSet
template-rendering-intentexplicitly for tintable nav assets.This helps ensure the icon reliably follows system/app tint.
Based on learnings: “set template-rendering-intent to 'template' for generic/system UI icons that should inherit the system tint.”Proposed update
"info" : { "author" : "xcode", "version" : 1 + }, + "properties" : { + "template-rendering-intent" : "template" } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@DashWallet/Resources/AppAssets.xcassets/Navigation` bar/controls-template.imageset/Contents.json around lines 19 - 23, Add the "template-rendering-intent": "template" property to the controls-template.imageset Contents.json so the nav control asset is treated as a template image and inherits the system/app tint; update the JSON (in the same object that contains "info") to include the "template-rendering-intent" key set to "template" for the controls-template.imageset asset.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@DashWallet/Resources/AppAssets.xcassets/Navigation`
bar/controls-info.imageset/Contents.json:
- Around line 19-23: The imageset "controls-info.imageset" (the "info" entry in
Contents.json) lacks a template rendering intent; update its Contents.json to
add the "template-rendering-intent" key with value "template" for the "info"
image so the icon inherits system tint (i.e., set "template-rendering-intent":
"template" for the "info" imageset entry).
In `@DashWallet/Resources/AppAssets.xcassets/Navigation`
bar/controls-template.imageset/Contents.json:
- Around line 19-23: Add the "template-rendering-intent": "template" property to
the controls-template.imageset Contents.json so the nav control asset is treated
as a template image and inherits the system/app tint; update the JSON (in the
same object that contains "info") to include the "template-rendering-intent" key
set to "template" for the controls-template.imageset asset.
In `@DashWallet/Resources/AppAssets.xcassets/Navigation`
bar/toolbar-back.imageset/Contents.json:
- Around line 52-55: The Contents.json for the toolbar-back.imageset is missing
the template rendering intent used by other toolbar icons; update the
Contents.json inside toolbar-back.imageset to include the
"template-rendering-intent" key with the value "template" (matching
toolbar-close.imageset) so the toolbar-back asset will inherit system tinting as
a template image.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6998e149-bc36-4996-9dcc-58b5a06463a8
⛔ Files ignored due to path filters (239)
DashWallet/Resources/AppAssets.xcassets/Dash logo/dash-logo-black.imageset/dash-logo-black.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Dash logo/dash-logo-black.imageset/dash-logo-black@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Dash logo/dash-logo-black.imageset/dash-logo-black@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/csv-export-large.imageset/export.csv.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/csv-export-large.imageset/export.csv@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/csv-export-large.imageset/export.csv@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/image.import.private.key.large.imageset/import.private.key.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/image.import.private.key.large.imageset/import.private.key@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/image.import.private.key.large.imageset/import.private.key@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/maya-illustration.imageset/illustration-maya@1x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/maya-illustration.imageset/illustration-maya@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/maya-illustration.imageset/illustration-maya@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/zenledger-large.imageset/zenledger-large.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/zenledger-large.imageset/zenledger-large@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/zenledger-large.imageset/zenledger-large@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/zenledger_large.imageset/zenledger_large.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/zenledger_large.imageset/zenledger_large@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Illustration/zenledger_large.imageset/zenledger_large@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/Image.face.id.imageset/Layer 1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/Image.face.id.imageset/Layer 1@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/Image.face.id.imageset/Layer 1@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-advanced_security.imageset/image-menu-advanced_security.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-advanced_security.imageset/image-menu-advanced_security@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-advanced_security.imageset/image-menu-advanced_security@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-atm.imageset/image-menu-atm.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-atm.imageset/image-menu-atm@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-atm.imageset/image-menu-atm@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-autohide_balance.imageset/image-menu-autohide_balance.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-autohide_balance.imageset/image-menu-autohide_balance@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-autohide_balance.imageset/image-menu-autohide_balance@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-change_pin.imageset/image-menu-pin.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-change_pin.imageset/image-menu-pin@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-change_pin.imageset/image-menu-pin@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-enable_touch_id.imageset/image-menu-touch_id.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-enable_touch_id.imageset/image-menu-touch_id@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-enable_touch_id.imageset/image-menu-touch_id@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-face_id.imageset/image-menu-face_id.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-face_id.imageset/image-menu-face_id@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-face_id.imageset/image-menu-face_id@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-merchant.imageset/image-menu-merchant.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-merchant.imageset/image-menu-merchant@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-merchant.imageset/image-menu-merchant@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-recovery_phrase.imageset/image-menu-recovery_phrase.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-recovery_phrase.imageset/image-menu-recovery_phrase@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-recovery_phrase.imageset/image-menu-recovery_phrase@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-reset_wallet.imageset/image-menu-reset_wallet.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-reset_wallet.imageset/image-menu-reset_wallet@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-reset_wallet.imageset/image-menu-reset_wallet@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-staking.imageset/image-menu-staking.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-staking.imageset/image-menu-staking@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-staking.imageset/image-menu-staking@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.about.imageset/dash.logo.circle.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.about.imageset/dash.logo.circle@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.about.imageset/dash.logo.circle@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.advanced.security.imageset/advanced security.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.advanced.security.imageset/advanced security@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.advanced.security.imageset/advanced security@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.autohide.balance.imageset/eye.closed.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.autohide.balance.imageset/eye.closed@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.autohide.balance.imageset/eye.closed@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.buy.and.sell.imageset/buy.sell.dash.2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.buy.and.sell.imageset/buy.sell.dash.2@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.buy.and.sell.imageset/buy.sell.dash.2@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.change.pin.imageset/Layer_1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.change.pin.imageset/Layer_1@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.change.pin.imageset/Layer_1@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.coinjoin.menu.imageset/Layer_1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.coinjoin.menu.imageset/Layer_1@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.coinjoin.menu.imageset/Layer_1@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.coinjoin.menu.imageset/mixing.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.coinjoin.menu.imageset/mixing@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.coinjoin.menu.imageset/mixing@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.csv.export.imageset/csv-export.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.csv.export.imageset/csv-export@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.csv.export.imageset/csv-export@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.csv.export.imageset/csv.export.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.csv.export.imageset/csv.export@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.csv.export.imageset/csv.export@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.currency.imageset/cash.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.currency.imageset/cash@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.currency.imageset/cash@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.currency.imageset/local.currency.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.currency.imageset/local.currency@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.currency.imageset/local.currency@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.explore.imageset/Explore-Blue.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.explore.imageset/Explore-Blue@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.explore.imageset/Explore-Blue@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.explore.imageset/explore-2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.explore.imageset/explore-2@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.explore.imageset/explore-2@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.extend.public.key.imageset/extend-public-key.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.extend.public.key.imageset/extend-public-key@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.extend.public.key.imageset/extend-public-key@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.extend.public.key.imageset/public.key.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.extend.public.key.imageset/public.key@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.extend.public.key.imageset/public.key@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.import.private.key.imageset/import-private-key.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.import.private.key.imageset/import-private-key@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.import.private.key.imageset/import-private-key@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.import.private.key.imageset/import.private.key.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.import.private.key.imageset/import.private.key@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.import.private.key.imageset/import.private.key@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.masternode.keys.imageset/Layer_1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.masternode.keys.imageset/Layer_1@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.masternode.keys.imageset/Layer_1@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.masternode.keys.imageset/masternode-keys.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.masternode.keys.imageset/masternode-keys@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.masternode.keys.imageset/masternode-keys@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.network.monitor.imageset/Layer_1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.network.monitor.imageset/Layer_1@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.network.monitor.imageset/Layer_1@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.network.monitor.imageset/network-monitor.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.network.monitor.imageset/network-monitor@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.network.monitor.imageset/network-monitor@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.notifications.imageset/Layer 1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.notifications.imageset/Layer 1@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.notifications.imageset/Layer 1@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.notifications.imageset/notification.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.notifications.imageset/notification@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.notifications.imageset/notification@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.recovery.phrase.imageset/Layer_1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.recovery.phrase.imageset/Layer_1@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.recovery.phrase.imageset/Layer_1@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.rescan.imageset/rescan.blockchain.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.rescan.imageset/rescan.blockchain@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.rescan.imageset/rescan.blockchain@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.reset.wallet.imageset/reset wallet.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.reset.wallet.imageset/reset wallet@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.reset.wallet.imageset/reset wallet@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.security.imageset/Vector.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.security.imageset/Vector@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.security.imageset/Vector@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.security.imageset/security.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.security.imageset/security@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.security.imageset/security@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.settings.imageset/Iconly_x2F_Bold_x2F_Setting.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.settings.imageset/Iconly_x2F_Bold_x2F_Setting@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.settings.imageset/Iconly_x2F_Bold_x2F_Setting@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.settings.imageset/settings.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.settings.imageset/settings@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.settings.imageset/settings@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.support.imageset/Group.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.support.imageset/Group@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.support.imageset/Group@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.support.imageset/support.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.support.imageset/support@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.support.imageset/support@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.tools.imageset/Group.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.tools.imageset/Group@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.tools.imageset/Group@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.tools.imageset/tools.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.tools.imageset/tools@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.tools.imageset/tools@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.touch.id.imageset/fingerprint.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.touch.id.imageset/fingerprint@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/image.touch.id.imageset/fingerprint@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/masternode-keys.imageset/masternode-keys@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/masternode-keys.imageset/masternode-keys@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/masternode-keys.imageset/masternode-keys@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_buySellDash.imageset/menu_buySellDash.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_buySellDash.imageset/menu_buySellDash@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_buySellDash.imageset/menu_buySellDash@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_buySellDash.imageset/menu_buySellDash_dark.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_buySellDash.imageset/menu_buySellDash_dark@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_buySellDash.imageset/menu_buySellDash_dark@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_security.imageset/menu_security.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_security.imageset/menu_security@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_security.imageset/menu_security@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_security.imageset/menu_security_dark.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_security.imageset/menu_security_dark@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_security.imageset/menu_security_dark@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_settings.imageset/levels.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_settings.imageset/levels@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_settings.imageset/levels@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_settings.imageset/menu_settings.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_settings.imageset/menu_settings@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_settings.imageset/menu_settings@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_support.imageset/menu_support.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_support.imageset/menu_support@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_support.imageset/menu_support@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_tools.imageset/menu_tools.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_tools.imageset/menu_tools@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_tools.imageset/menu_tools@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_tools.imageset/tools.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_tools.imageset/tools@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/menu_tools.imageset/tools@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/service-coinbase.imageset/menu-coinbase.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/service-coinbase.imageset/menu-coinbase@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/service-coinbase.imageset/menu-coinbase@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/service-topper.imageset/menu-topper.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/service-topper.imageset/menu-topper@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/service-topper.imageset/menu-topper@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/service-uphold.imageset/menu-uphold.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/service-uphold.imageset/menu-uphold@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Menu/service-uphold.imageset/menu-uphold@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/controls-info.imageset/controls-info@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/controls-info.imageset/controls-info@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/controls-info.imageset/controls-info@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/controls-template.imageset/controls-template@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/controls-template.imageset/controls-template@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/controls-template.imageset/controls-template@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-back.imageset/control-back@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-back.imageset/control-back@3x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-back.imageset/toolbar-back-dark@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-back.imageset/toolbar-back-dark@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-back.imageset/toolbar-back-dark@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-back.imageset/toolbar-back@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-back.imageset/toolbar-back@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-back.imageset/toolbar-back@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-close.imageset/control-close@2x.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-close.imageset/toolbar-close@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-close.imageset/toolbar-close@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-close.imageset/toolbar-close@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-plus.imageset/toolbar-plus@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-plus.imageset/toolbar-plus@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-plus.imageset/toolbar-plus@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Other/qr.imageset/qr@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Other/qr.imageset/qr@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Other/qr.imageset/qr@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Shortcuts/shortcut_scanToPay.imageset/scan.svgis excluded by!**/*.svgDashWallet/Resources/AppAssets.xcassets/Toast/toast-error.imageset/toast-error@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-error.imageset/toast-error@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-error.imageset/toast-error@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-info.imageset/toast-info@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-info.imageset/toast-info@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-info.imageset/toast-info@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-loading.imageset/toast-loading@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-loading.imageset/toast-loading@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-loading.imageset/toast-loading@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-success.imageset/toast-success@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-success.imageset/toast-success@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-success.imageset/toast-success@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-warning-yellow.imageset/toast-warning-yellow@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-warning-yellow.imageset/toast-warning-yellow@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-warning-yellow.imageset/toast-warning-yellow@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-warning.imageset/toast-warning@x1.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-warning.imageset/toast-warning@x2.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/Toast/toast-warning.imageset/toast-warning@x3.pngis excluded by!**/*.pngDashWallet/Resources/AppAssets.xcassets/arrow-down.imageset/arrow-down@x1.pngis excluded by!**/*.png
📒 Files selected for processing (61)
DashSyncCurrentCommitDashWallet.xcodeproj/project.pbxprojDashWallet.xcodeproj/xcshareddata/xcschemes/dashwallet.xcschemeDashWallet/AppDelegate.mDashWallet/Resources/AppAssets.xcassets/Dash logo/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Dash logo/dash-logo-black.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Illustration/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Illustration/csv-export-large.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Illustration/image.import.private.key.large.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Illustration/maya-illustration.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Illustration/zenledger-large.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Illustration/zenledger_large.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-advanced_security.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-atm.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-autohide_balance.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-change_pin.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-enable_touch_id.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-face_id.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-merchant.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-recovery_phrase.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-reset_wallet.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image-menu-staking.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.coinjoin.menu.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.csv.export.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.currency.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.explore.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.extend.public.key.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.import.private.key.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.masternode.keys.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.network.monitor.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.notifications.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.reset.wallet.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.security.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.settings.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.support.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.tools.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/image.touch.id.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/masternode-keys.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/menu_security.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/menu_settings.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/menu_support.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/service-coinbase.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/service-topper.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Menu/service-uphold.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Navigation bar/controls-info.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Navigation bar/controls-template.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-back.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-close.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-info.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-plus.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Other/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Other/qr.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Toast/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Toast/toast-error.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Toast/toast-info.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Toast/toast-loading.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Toast/toast-success.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Toast/toast-warning-yellow.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Toast/toast-warning.imageset/Contents.jsonDashWallet/Resources/AppAssets.xcassets/Voting/Contents.jsonDashWallet/Resources/AppAssets.xcassets/arrow-down.imageset/Contents.json
💤 Files with no reviewable changes (6)
- DashWallet/Resources/AppAssets.xcassets/Navigation bar/toolbar-info.imageset/Contents.json
- DashWallet/Resources/AppAssets.xcassets/Menu/image.reset.wallet.imageset/Contents.json
- DashWallet/Resources/AppAssets.xcassets/Menu/image.touch.id.imageset/Contents.json
- DashWallet/Resources/AppAssets.xcassets/Menu/menu_settings.imageset/Contents.json
- DashWallet/Resources/AppAssets.xcassets/Menu/menu_support.imageset/Contents.json
- DashWallet/Resources/AppAssets.xcassets/Menu/menu_security.imageset/Contents.json
Issue being fixed or feature implemented
This PR implements the Maya sell conversion flow and order preview experience for iOS, including amount entry, quote handling, destination input, and transaction confirmation UX.
What was done?
Maxamount handling based on current DASH wallet balance.How Has This Been Tested?
Manual testing was performed on iOS Simulator (iPhone 14 Pro, iOS 18.6) and local debug builds.
Test scenarios covered:
Breaking Changes
No breaking changes introduced.
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit