Skip to content

F'up to #14654: Fix Boost test macro definitions#8590

Merged
chrchr-github merged 7 commits into
cppcheck-opensource:mainfrom
chrchr-github:chr_boostTest
May 29, 2026
Merged

F'up to #14654: Fix Boost test macro definitions#8590
chrchr-github merged 7 commits into
cppcheck-opensource:mainfrom
chrchr-github:chr_boostTest

Conversation

@chrchr-github
Copy link
Copy Markdown
Collaborator

@chrchr-github chrchr-github commented May 28, 2026

CI failure is unrelated.

@chrchr-github chrchr-github marked this pull request as ready for review May 28, 2026 07:51
@chrchr-github
Copy link
Copy Markdown
Collaborator Author

chrchr-github commented May 28, 2026

@ChristophStrehle Please review

@ChristophStrehle
Copy link
Copy Markdown
Contributor

@chrchr-github Thanks a lot for working on this fix — really appreciate it!

The changes look good to me overall. I gave it a try with the 2.20.0 release on our code base, and I noticed a few false positives with BOOST_FIXTURE_TEST_CASE. For example:

// failed to expand 'BOOST_FIXTURE_TEST_CASE', Wrong number of parameters for macro 'BOOST_FIXTURE_TEST_CASE'.
BOOST_FIXTURE_TEST_CASE(TestCase, Fixture, boost::unit_test::depends_on(TestCase1))
{

I just wanted to flag that in case it’s helpful.

@chrchr-github
Copy link
Copy Markdown
Collaborator Author

Thanks for the review, BOOST_FIXTURE_TEST_CASE is now also variadic.

@chrchr-github chrchr-github changed the title Fix Boost test macro definitions F'up to #14654: Fix Boost test macro definitions May 29, 2026
@chrchr-github chrchr-github merged commit bc2b84d into cppcheck-opensource:main May 29, 2026
82 of 84 checks passed
@chrchr-github chrchr-github deleted the chr_boostTest branch May 29, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants