Skip to content

ci: add zizmor workflow linting#4909

Open
omribz156 wants to merge 1 commit into
containerd:mainfrom
omribz156:codex/add-zizmor
Open

ci: add zizmor workflow linting#4909
omribz156 wants to merge 1 commit into
containerd:mainfrom
omribz156:codex/add-zizmor

Conversation

@omribz156
Copy link
Copy Markdown

Summary:

  • Add zizmor to the workflow lint CI.
  • Fix the workflow findings reported by zizmor, including token persistence, excessive permissions, setup-go caching, and template-injection warnings.

Verification:

  • uvx zizmor .github/workflows
  • C:\Users\omrib\go\bin\actionlint.exe -ignore 'not assignable' -ignore 'property "hack" is not defined'
  • git diff --check

Note: raw actionlint reports the same existing baseline findings on clean origin/main and this branch. With those baseline findings ignored, this branch does not add new actionlint findings.

This was implemented with Codex assistance, with the final diff reviewed before posting.

Comment thread .github/workflows/workflow-lint.yml Outdated
uses: zizmorcore/zizmor-action@b1d7e1fb5de872772f31590499237e7cce841e8e # v0.5.3
with:
inputs: .github/workflows
# Do not send workflow diagnostics to GHAS in this project right now.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is GHAS

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded this to GitHub Advanced Security code scanning in the comment so the acronym is not floating around unexplained.

@AkihiroSuda
Copy link
Copy Markdown
Member

Please squash the commits, then LGTM

Signed-off-by: Omri SirComp <omribz156@gmail.com>
@omribz156
Copy link
Copy Markdown
Author

Thanks, squashed into one signed-off commit and force-pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants