Dev

[codad5]

This pull request introduces significant enhancements to the APIHelper and EnqueueManager utilities, as well as improvements to the view/template loading system. The main changes include a complete overhaul of how API request bodies are handled, new methods for registering and enqueuing scripts/styles, and the introduction of a dedicated ViewHelper class for cleaner template usage. There are also improvements to frontend page handling and template fallback logic.

API Request Handling Improvements:

• Refactored APIHelper to support separate handling of query parameters and request bodies, including new logic for merging, filtering, and preparing the body based on content type. This includes new methods such as prepare_request_body, get_default_content_type, and resolve_content_type, and updates to the request and make_request signatures to accept a $body parameter. [1] [2] [3] [4] [5] [6] [7] [8]

Script and Style Registration Enhancements:

• Added a suite of new methods to EnqueueManager for registering scripts and styles (individually, in groups, or by handle) without enqueuing them, as well as methods to enqueue previously registered assets and check their registration status. This enables more flexible and performant asset management.

View and Template Loading Improvements:

• Introduced a new ViewHelper class, providing a clean API for loading, including, and managing sections in views, and integrated it into the ViewLoader system. The view helper is now passed to templates as the $view variable, replacing the previous anonymous class approach. [1] [2] [3] [4]
• Updated ViewLoader::load to support plugin prefix and overridable templates, improving theme override support.

Frontend Page and Template Handling:

• Improved frontend page callback logic in Page to allow direct callback output and prevent further template processing when a callback is present. Also, improved the default template fallback message. [1] [2] [3]

Codebase Cleanup:

• Removed an unused import (Cache) from ViewLoader.php.

[Copilot]

Pull request overview

This PR modernizes several WPToolkit utilities by expanding HTTP request handling (separating query params vs request body), adding manual registration/enqueue controls for scripts/styles, and refactoring the view/template system to use a dedicated ViewHelper plus improved template override resolution.

Changes:

• Refactors APIHelper request/make_request to accept a dedicated $body payload and introduces content-type-aware body preparation.
• Extends EnqueueManager with methods to register assets/groups without enqueuing and to enqueue already-registered handles.
• Introduces ViewHelper for templates and updates ViewLoader to support theme overrides; adjusts frontend page template/callback behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/Utils/ViewLoader.php	Adds overridable theme template resolution and switches template helper injection to a ViewHelper instance.
src/Utils/ViewHelper.php	New helper class intended to be injected into templates as $view for loading/sections.
src/Utils/Page.php	Alters frontend template_include behavior for callback handling and changes default template fallback behavior.
src/Utils/EnqueueManager.php	Adds registration-only APIs and enqueue-by-handle APIs for previously registered scripts/styles.
src/Utils/APIHelper.php	Splits query params from request body, adds body preparation helpers, and updates request/make_request signatures.

Comments suppressed due to low confidence (3)

src/Utils/Page.php:1142

• getFrontendTemplate() is documented/used as returning a template path, but the fallback now returns a plain human-readable message string. WordPress will treat that string as a filename and try to include it. Revert to returning a valid template path (e.g., createDefaultFrontendTemplate(...)) or otherwise ensure a real file is returned for the template_include hook.

		}

		// Create default template
		return "This page has no template configured. Please create a template file named '{$slug}.php' in your plugin or theme directory.";
	}

src/Utils/ViewLoader.php:633

• handle_template_not_found() / handle_render_error() are documented as returning false and always return false, but their return type was widened to bool. This can be tightened back to false to match the docblock and make intent clearer (and avoid implying true is a meaningful return value).

This issue also appears on line 642 of the same file.

    private static function handle_template_not_found(string $view, bool $echo): bool
    {
        $error_message = "Template not found: {$view}";

        if (defined('WP_DEBUG') && WP_DEBUG) {
            if ($echo) {
                echo "<div class=\"wptoolkit-error\">{$error_message}</div>";
            }
            error_log("ViewLoader: {$error_message}");
        }

        return false;
    }

src/Utils/ViewLoader.php:654

• handle_render_error() is documented as returning false and always returns false, but its return type is bool. Consider tightening the return type back to false to better reflect actual behavior and intent.

    private static function handle_render_error(string $view, bool $echo): bool
    {
        $error_message = "Error rendering template: {$view}";

        if (defined('WP_DEBUG') && WP_DEBUG) {
            if ($echo) {
                echo "<div class=\"wptoolkit-error\">{$error_message}</div>";
            }
            error_log("ViewLoader: {$error_message}");
        }

        return false;
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.