package: improvements#44
Conversation
Creates repo file for RPM packages
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to create RPM repository metadata for built packages using createrepo. The changes modify the CentOS/RPM build path to fix outdated CentOS repository URLs (switching from mirror.centos.org to vault.centos.org) and then generate repository metadata in the /output directory where built RPM packages are stored.
Key Changes:
- Adds CentOS repository URL fixes to enable package installation on systems where mirror.centos.org is no longer accessible
- Installs and runs createrepo to generate RPM repository metadata for packages in /output
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dnf install createrepo -y || true | ||
| createrepo /output |
There was a problem hiding this comment.
If the dnf install createrepo command fails (suppressed by || true), the subsequent createrepo command on line 224 will fail with an unclear error message about the command not being found. Consider checking whether createrepo was successfully installed before attempting to use it, or remove the || true to ensure the build fails fast with a clear error if the package cannot be installed.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.