Add debian-13 to build-base-images workflow matrix#2259
Open
larsewi wants to merge 5 commits into
Open
Conversation
Without this, no debian-13 image gets pushed to ghcr.io, which in turn breaks the weekly Update base image versions workflow when it tries to query tags for cfengine-builder-debian-13. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
The previous wording claimed that adding a Debian/Ubuntu platform required only a new entry in platforms.json, which misses the build-base-images workflow matrix and leads to the update-base-images job crashing with a 403 from ghcr.io. Also added debian-13 to the supported platforms table. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Explain that image_version should start as "latest" (the update workflow will replace it after the first push) and that base_image_sha should be filled in by ./build-in-container.py --update-sha rather than copied by hand. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, no
debian-13image is pushed toghcr.ioand the weeklyUpdate base image versionsworkflow crashes with a 403 when it queries tags for the missing repository.Also fills in gaps in
build-in-container.md: adding a new platform requires both aplatforms.jsonentry and a matrix entry,image_versionshould start as"latest",base_image_shais filled in by--update-sha, and the--update-shaflag andupdate-base-image-shas.ymlworkflow are now documented.