feat: make slash command menu a listbox for screen reader support#16
Open
wesgro wants to merge 2 commits into
Open
feat: make slash command menu a listbox for screen reader support#16wesgro wants to merge 2 commits into
listbox for screen reader support#16wesgro wants to merge 2 commits into
Conversation
This change allows screen readers to correctly announce that they are in a list box view. Slash command menu options are then announced as the user arrow keys through them.
❌ Deploy Preview for fancygist failed. Why did it fail? →
|
Owner
|
Thank you!! |
Owner
|
I tested this a bit and wasn't able to get my screen reader to work with these changes. Would you mind taking another look, and/or give me a test walkthrough I can try? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows screen readers to correctly announce that they are in a list box view. Slash command menu options are then announced as the user arrow keys through them.
Closes #15