Skip to content

test(integration): verify response content-types across HTTP routes#627

Merged
cameri merged 2 commits into
cameri:mainfrom
Ferryx349:m3
May 30, 2026
Merged

test(integration): verify response content-types across HTTP routes#627
cameri merged 2 commits into
cameri:mainfrom
Ferryx349:m3

Conversation

@Ferryx349
Copy link
Copy Markdown
Collaborator

Fixes - #533

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 25, 2026

🦋 Changeset detected

Latest commit: be2707f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nostream Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 25, 2026

Coverage Status

coverage: 66.977% (+0.8%) from 66.153% — Ferryx349:m3 into cameri:main

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Cucumber integration feature to verify that key HTTP endpoints return the expected Content-Type (and status codes), addressing Issue #533’s request to validate response types across routes.

Changes:

  • Add a new integration feature (response-types) that exercises several GET/POST HTTP routes and asserts status + Content-Type.
  • Add step definitions to issue HTTP requests for the new feature.
  • Add a changeset entry for the test addition.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
test/integration/features/response-types/response-types.feature.ts Adds Cucumber step definitions to make HTTP requests (GET/POST) and store the response in the World state.
test/integration/features/response-types/response-types.feature Adds scenario outlines covering core GET/POST routes and expected Content-Type values.
.changeset/response-types-integration-tests.md Adds a changeset entry documenting the new integration coverage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .changeset/response-types-integration-tests.md
Comment thread test/integration/features/response-types/response-types.feature Outdated
Comment thread test/integration/features/response-types/response-types.feature Outdated
Comment thread test/integration/features/response-types/response-types.feature Outdated
Comment thread test/integration/features/response-types/response-types.feature.ts Outdated
Comment thread test/integration/features/response-types/response-types.feature.ts
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@cameri
Copy link
Copy Markdown
Owner

cameri commented May 26, 2026

Some of these tests are calling endpoints that are disabled, so the tests should likely enable the feature before making the HTTP call so you don't just get a 4xx response.

Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>
@Ferryx349
Copy link
Copy Markdown
Collaborator Author

Some of these tests are calling endpoints that are disabled, so the tests should likely enable the feature before making the HTTP call so you don't just get a 4xx response.

Fixed it, please review

@cameri cameri merged commit c87dd03 into cameri:main May 30, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants