feat: expose cache entry on shouldUpdateScript#1319
Conversation
🦋 Changeset detectedLatest commit: bbaaba4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@ElielC is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
|
Nice one @ElielC 🙌 |
|
The changeset bot references the release as a Major, but i created the changeset as a Minor release, is that right? |
|
Thats strange, @jbroma is this a bug with the changesets bot? |
hey, sorry for lack of activity lately, changesets can always be adjusted manually before the release so no need to worry about that |
MikitasK
left a comment
There was a problem hiding this comment.
overall, these changes looks good to me 👍 also core behavior works as expected on my side ☑️
just a few minor comments:
|
This looks like a solid addition! Could you add a test case that specifically covers this scenario ? |
|
Hello, sorry for taking too long and thanks for the feedback. I will be implementing the suggested comments! |
Co-authored-by: Mikita Kliushun <nikita.kliushun@gmail.com>
|
Deployment failed with the following error: |
Co-authored-by: Mikita Kliushun <nikita.kliushun@gmail.com>
Summary
Exposes a new property on
locator.shouldUpdateScriptin order to enable more custom caching behaviors onafterResolvehooks, following this discussionTest plan
Ensure all tests pass and there are no regression issues