refactor: improve structure of reference and system tokens#4952
Open
adrcotfas wants to merge 1 commit into
Open
refactor: improve structure of reference and system tokens#4952adrcotfas wants to merge 1 commit into
adrcotfas wants to merge 1 commit into
Conversation
* add focusIndicator tokens
|
The mobile version of example app from this branch is ready! You can see it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Foundation prep for the Switch component modernization.
Three things:
md.sys.state.focusIndicator(thickness: 3, outerOffset: 2). Matches MD3 spec. Switch will be the first consumer.reftosysper the MD3 spec:-
ref.stateOpacity->sys.state.opacity-
ref.scrimAlpha->sys.scrim.alphaAlso in this PR:
getStateLayer(theme, role, state)in theme/utils/state.ts. Returns { color, opacity }. Four components migrated: HelperText, TextInput/Adornment, CheckboxItem, RadioButtonItem.ColorRole = keyof ThemeColors and StateOpacityKey = keyof typeof tokens.md.sys.state.opacity. Component token files can use them to validate string keys.No change to Theme. Renames are internal only.
Related issue
N/A. Prep for Switch modernization.
Test plan