Skip to content

fix python 3.14.5 and 3.7.4-3.10.x darwin builds#129

Open
domenkozar wants to merge 2 commits into
mainfrom
fix/python-3.10-3.14.5-build
Open

fix python 3.14.5 and 3.7.4-3.10.x darwin builds#129
domenkozar wants to merge 2 commits into
mainfrom
fix/python-3.10-3.14.5-build

Conversation

@domenkozar
Copy link
Copy Markdown
Member

Summary

Fixes #127
Fixes #115

Test plan

  • `nix build .#"3.14.5"` succeeds against pinned nixpkgs (25.11)
  • `nix build .#"3.14.5"` succeeds against nixpkgs master (which contains the offending hacl patch)
  • `nix build .#"3.14.4"` still succeeds against master (patch still applied as before)
  • `patch -p1 --dry-run` of vendored distutils-C++ patch applies cleanly to 3.7.4, 3.7.17, 3.8.20, 3.9.23, and 3.10.20 sources
  • CI passes on darwin (Linux skips the distutils-C++ patch entirely)

🤖 Generated with Claude Code

domenkozar and others added 2 commits May 18, 2026 11:37
The patch was merged upstream in CPython 3.14.5 (gh-146264), so applying
it from nixpkgs fails with "Reversed (or previously applied) patch
detected" when our source override pulls in 3.14.5.

Fixes #127

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Nixpkgs commit 77ca0804 (python310: drop) removed the local
./3.7/python-3.x-distutils-C++.patch, leaving a fetchpatch fallback that
no longer applies to 3.7.4+. Vendor the working pre-drop patch and use
it via replacePatch for the affected range.

Only impacts Darwin builds, since hasDistutilsCxxPatch is gated on
!stdenv.cc.isGNU.

Fixes #115

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failed for python 3.14.5 Python 3.10 fails to apply python-3.x-distutils-C++.patch

1 participant