fix python 3.14.5 and 3.7.4-3.10.x darwin builds#129
Open
domenkozar wants to merge 2 commits into
Open
Conversation
The patch was merged upstream in CPython 3.14.5 (gh-146264), so applying it from nixpkgs fails with "Reversed (or previously applied) patch detected" when our source override pulls in 3.14.5. Fixes #127 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Nixpkgs commit 77ca0804 (python310: drop) removed the local ./3.7/python-3.x-distutils-C++.patch, leaving a fetchpatch fallback that no longer applies to 3.7.4+. Vendor the working pre-drop patch and use it via replacePatch for the affected range. Only impacts Darwin builds, since hasDistutilsCxxPatch is gated on !stdenv.cc.isGNU. Fixes #115 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hacl-static-ldeps-for-static-modules.patchfor 3.14.5+, since the fix was merged upstream in CPython 3.14.5 (gh-146264: Use static HACL deps for static module builds python/cpython#146265). Nixpkgs still applies the patch for the whole 3.14.x range, which broke when our source override pulls in 3.14.5.Fixes #127
Fixes #115
Test plan
🤖 Generated with Claude Code