Skip to content

refactor: use salsa#10315

Draft
ematipico wants to merge 7 commits into
nextfrom
feat/salsa-db
Draft

refactor: use salsa#10315
ematipico wants to merge 7 commits into
nextfrom
feat/salsa-db

Conversation

@ematipico
Copy link
Copy Markdown
Member

Summary

Test Plan

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 9, 2026

⚠️ No Changeset found

Latest commit: d93ef14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS and super languages L-JSON Language: JSON and super languages A-Diagnostic Area: diagnostocis L-HTML Language: HTML and super languages L-Grit Language: GritQL A-Type-Inference Area: type inference A-Resolver Area: resolver labels May 9, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 9, 2026

Merging this PR will degrade performance by 69.7%

⚡ 3 improved benchmarks
❌ 13 regressed benchmarks
✅ 233 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
js_analyzer[css_16118272471217147034.js] 32.9 ms 36.2 ms -9.33%
js_analyzer[index_3894593175024091846.js] 69.6 ms 77.5 ms -10.13%
js_analyzer[parser_13571644119461115204.ts] 124.4 ms 140.1 ms -11.2%
js_analyzer[router_17129688031671448157.ts] 35.7 ms 39.4 ms -9.43%
js_analyzer[statement_263793315104667298.ts] 113.6 ms 128.5 ms -11.6%
js_analyzer[typescript_3735799142832611563.ts] 176 ms 201.9 ms -12.84%
html_analyzer[real/wikipedia-fr-Guerre_de_Canudos.html] 448.6 ms 1,268.9 ms -64.64%
html_analyzer[index_1033418810622582172.html] 477.3 µs 1,190.5 µs -59.91%
html_analyzer[real/wikipedia-JavaScript.html] 188 ms 620.4 ms -69.7%
html_analyzer[real/wikipedia-Unix.html] 164.9 ms 513.4 ms -67.87%
css_analyzer[foundation_11602414662825430680.css] 236.6 ms 273.2 ms -13.42%
css_analyzer[pure_9395922602181450299.css] 23.4 ms 26.6 ms -11.88%
css_analyzer[tachyons_11778168428173736564.css] 177.2 ms 195.9 ms -9.56%
execute_optimized[code_snippet] 447.6 µs 410.4 µs +9.06%
execute_optimized[or_pattern] 582.3 µs 536.4 µs +8.57%
execute_optimized[where_clause] 447.7 µs 405.9 µs +10.28%

Comparing feat/salsa-db (d93ef14) with next (5b57d62)

Open in CodSpeed

@github-actions github-actions Bot removed A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-Grit Language: GritQL labels May 9, 2026
@Netail
Copy link
Copy Markdown
Member

Netail commented May 10, 2026

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Diagnostic Area: diagnostocis A-Linter Area: linter A-LSP Area: language server protocol A-Project Area: project A-Resolver Area: resolver A-Type-Inference Area: type inference L-CSS Language: CSS and super languages L-HTML Language: HTML and super languages L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants