Skip to content

chore(xtask): scaffold global-types codegen and resolver builder#10249

Draft
minseong0324 wants to merge 1 commit into
biomejs:mainfrom
minseong0324:chore/global-types-codegen-pr1
Draft

chore(xtask): scaffold global-types codegen and resolver builder#10249
minseong0324 wants to merge 1 commit into
biomejs:mainfrom
minseong0324:chore/global-types-codegen-pr1

Conversation

@minseong0324
Copy link
Copy Markdown
Contributor

@minseong0324 minseong0324 commented May 5, 2026

This PR was implemented with AI assistance from Codex.

Summary

Foundation for #5977. Adds an xtask_codegen global-types command (gated behind the global_types feature) that pins TypeScript v5.9.3, walks the default-library closure, and emits an empty crates/biome_js_type_info/src/codegen/global_types.rs. The globals_ids.rs manifest macro consolidates ID/name/resolved-ID tables into a single ordered source of truth, and GlobalsResolverBuilder now asserts on out-of-bounds, double-write, and unset-slot writes.

Test Plan

green CI

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026

⚠️ No Changeset found

Latest commit: a10a43e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages A-Type-Inference Area: type inference labels May 5, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 5, 2026

Merging this PR will not alter performance

✅ 249 untouched benchmarks


Comparing minseong0324:chore/global-types-codegen-pr1 (a10a43e) with main (83f7385)

Open in CodSpeed

@minseong0324 minseong0324 force-pushed the chore/global-types-codegen-pr1 branch 24 times, most recently from 1482ec2 to 30a9e19 Compare May 9, 2026 18:11
@minseong0324 minseong0324 changed the title chore(xtask): scaffold global-types codegen with manifest-driven globals and strict resolver builder chore(xtask): scaffold global-types codegen and resolver builder May 9, 2026
@minseong0324 minseong0324 force-pushed the chore/global-types-codegen-pr1 branch 4 times, most recently from 4eac861 to f7df73e Compare May 13, 2026 01:06
@minseong0324 minseong0324 force-pushed the chore/global-types-codegen-pr1 branch from f7df73e to a10a43e Compare May 13, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Tooling Area: internal tools A-Type-Inference Area: type inference L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant