chore(xtask): scaffold global-types codegen and resolver builder#10249
Draft
minseong0324 wants to merge 1 commit into
Draft
chore(xtask): scaffold global-types codegen and resolver builder#10249minseong0324 wants to merge 1 commit into
minseong0324 wants to merge 1 commit into
Conversation
|
Merging this PR will not alter performance
Comparing |
1482ec2 to
30a9e19
Compare
4eac861 to
f7df73e
Compare
f7df73e to
a10a43e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was implemented with AI assistance from Codex.
Summary
Foundation for #5977. Adds an
xtask_codegen global-typescommand (gated behind theglobal_typesfeature) that pins TypeScript v5.9.3, walks the default-library closure, and emits an emptycrates/biome_js_type_info/src/codegen/global_types.rs. Theglobals_ids.rsmanifest macro consolidates ID/name/resolved-ID tables into a single ordered source of truth, andGlobalsResolverBuildernow asserts on out-of-bounds, double-write, and unset-slot writes.Test Plan
green CI