refactor(line_index): use SIMD intrinsics for better performance#10221
Draft
dyc3 wants to merge 1 commit into
Draft
refactor(line_index): use SIMD intrinsics for better performance#10221dyc3 wants to merge 1 commit into
dyc3 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This essentially uses SIMD intrinsics to add a ASCII fast path to the scanning that
LineIndexdoes. On my machine, the benchmarks indicate speedups from ~1.5 GB/s to anywhere between ~2.8-10+ GB/s throughput. Notably, there is a regression in speed when (approximately 0.33x) for text that is made of majority unicode text. For most code (particularly JS, CSS, GraphQL), this is likely not going to be a problem, but HTML and JSON documents are more likely to have problems because those usually contain data that is meant for humans to read.I used gpt 5.5 to do the initial research and the implementations.
Test Plan
Tested locally on my x64 machine
Using CI to test the ARM path since our runners are ARM based.
Docs