Pack initialized with adminCount in MockB20 storage#39
Merged
Conversation
Reduce layout footprint by packing `initialized` into the adminCount slot and update factory bootstrap writes to set only the initialized byte without clobbering packed data. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initializedwithadminCountinMockB20Storage.Layoutby narrowingadminCounttouint248and colocating the flag in slot 8.ADMIN_COUNT_OFFSETandINITIALIZED_OFFSETboth point to slot 8, and addINITIALIZED_BYTE_OFFSETfor byte-precise writes.initialized=truefrom clobbering packedadminCount.Test plan
forge test --match-path "test/unit/TokenFactory/*.t.sol"forge test --match-path "test/unit/B20/roles/*.t.sol"forge test --match-path "test/unit/storage/*.t.sol"Made with Cursor